Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(322)

Issue 7030060: Avoid loading the last not secure resource

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by frankban
Modified:
7 years, 9 months ago
Reviewers:
teknico, mp+141874
Visibility:
Public.

Description

Avoid loading the last not secure resource I.e. the Ubuntu font. https://code.launchpad.net/~frankban/juju-gui/bug-1095324-external-resources/+merge/141874 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Avoid loading the last not secure resource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
7 years, 9 months ago (2013-01-04 09:45:21 UTC) #1
frankban
Self review: trivial, just s/http/https/, as suggested in the bug comments. I will proceed landing ...
7 years, 9 months ago (2013-01-04 09:47:50 UTC) #2
frankban
*** Submitted: Avoid loading the last not secure resource I.e. the Ubuntu font. R= CC= ...
7 years, 9 months ago (2013-01-04 09:50:06 UTC) #3
teknico
I'll approve anyway, land as is. :-)
7 years, 9 months ago (2013-01-04 09:50:30 UTC) #4
frankban
7 years, 9 months ago (2013-01-04 09:51:05 UTC) #5
On 2013/01/04 09:50:30, teknico wrote:
> I'll approve anyway, land as is. :-)

Eh... thanks! :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b