Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 7030056: Update HACKING to reflect current state.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by bac
Modified:
7 years, 9 months ago
Reviewers:
mp+141747
Visibility:
Public.

Description

Update HACKING to reflect current state. The HACKING document was out-of-date regarding dependencies, required steps, etc. Following the instructions on a newly installed, non-developer machine showed the places where packages were missing. https://code.launchpad.net/~bac/juju-gui/hacking/+merge/141747 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update HACKING to reflect current state. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M HACKING View 1 4 chunks +18 lines, -8 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
7 years, 9 months ago (2013-01-03 13:21:38 UTC) #1
frankban
Land as is. Just a question in the comments below, otherwise, this branch is nice, ...
7 years, 9 months ago (2013-01-03 15:21:37 UTC) #2
teknico
Land as is (barring the one redundant blank line).
7 years, 9 months ago (2013-01-03 15:53:52 UTC) #3
bac
Thanks for the reviews. https://codereview.appspot.com/7030056/diff/1/HACKING File HACKING (right): https://codereview.appspot.com/7030056/diff/1/HACKING#newcode74 HACKING:74: On 2013/01/03 15:21:37, frankban wrote: ...
7 years, 9 months ago (2013-01-03 16:14:12 UTC) #4
bac
7 years, 9 months ago (2013-01-03 16:16:08 UTC) #5
*** Submitted:

Update HACKING to reflect current state.

The HACKING document was out-of-date regarding dependencies, required steps,
etc.  Following the instructions on a newly installed, non-developer machine
showed the places where packages were missing.

R=frankban, teknico
CC=
https://codereview.appspot.com/7030056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b