Issue 7030047: code review 7030047: cmd/5g: allow optimization of return registers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7030047: code review 7030047: cmd/5g: allow optimization of return registers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by minux1

Modified:
12 years, 6 months ago

Reviewers:

CC:
dave_cheney.net, rsc, golang-dev

Visibility:
Public.

Description

cmd/5g: allow optimization of return registers. Modeled after CL 7030046 by daniel.morsing. example program: func f(x int) int { x -= 10; return x } 5g -S difference: --- prog list "f" --- 0011 (x.go:7) TEXT add+0(SB),$0-8 0012 (x.go:7) MOVW x+0(FP),R0 -0013 (x.go:7) SUB $10,R0,R2 -0014 (x.go:7) MOVW R2,R0 -0015 (x.go:7) MOVW R2,.noname+4(FP) -0016 (x.go:7) RET , +0013 (x.go:7) SUB $10,R0 +0014 (x.go:7) MOVW R0,.noname+4(FP) +0015 (x.go:7) RET ,

Patch Set 1 #

Patch Set 2 : diff -r 88ae367d61aa https://code.google.com/p/go/ #

Patch Set 3 : diff -r 88ae367d61aa https://code.google.com/p/go/ #

Patch Set 4 : diff -r 68ae719b2335 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 68ae719b2335 https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	src/cmd/5g/peep.c	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM. func add() int { var a = 1 a += 2 return a } ...

12 years, 6 months ago (2012-12-30 22:10:51 UTC) #1

minux1

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 6 months ago (2012-12-30 22:21:11 UTC) #2

minux1

12 years, 6 months ago (2013-01-11 04:29:27 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=0f40abacc6ee ***

cmd/5g: allow optimization of return registers.
Modeled after CL 7030046 by daniel.morsing.

example program:
func f(x int) int { x -= 10; return x }

5g -S difference:
 --- prog list "f" ---
 0011 (x.go:7) TEXT   	add+0(SB),$0-8
 0012 (x.go:7) MOVW   	x+0(FP),R0
-0013 (x.go:7) SUB    	$10,R0,R2
-0014 (x.go:7) MOVW   	R2,R0
-0015 (x.go:7) MOVW   	R2,.noname+4(FP)
-0016 (x.go:7) RET    	,
+0013 (x.go:7) SUB    	$10,R0
+0014 (x.go:7) MOVW   	R0,.noname+4(FP)
+0015 (x.go:7) RET    	,

R=dave, rsc
CC=golang-dev
https://codereview.appspot.com/7030047

Expand All Messages | Collapse All Messages