Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15497)

Issue 7029043: PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Jean-Charles
Modified:
11 years, 3 months ago
Reviewers:
Graham Percival, benko.pal, dak, phileholmes
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES Introduced with version 1.0.1 : in stepmake/stepmake/C.make ALL_C_SOURCES = h, c, y and l files in stepmake/stepmake/Targets.make ALL_PO_SOURCES = $(ALL_C_SOURCES) $(wildcard $(outdir)/*.hh) $(wildcard $(outdir)/*.cc) hh and cc files having since then been registered through ALL_CC_SOURCES, there is no need to double their entry, Even worse, an "out of tree build" results in a doubled location of parser.yy and lexer.ll (one with a full path).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M stepmake/stepmake/po-targets.make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Jean-Charles
Please review
11 years, 4 months ago (2012-12-29 18:53:02 UTC) #1
benko.pal
11 years, 4 months ago (2012-12-31 11:39:24 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b