code review 7028051: bytes: fix docs: s/array/slice/.

bytes: fix docs: s/array/slice/.

[nigeltao, 2013-01-04 02:31:05]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, mdempsky@google.com),

I'd like you to review this change to
https://code.google.com/p/go

[mdempsky, 2013-01-04 02:35:27]

LGTM

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go
File src/pkg/bytes/bytes.go (right):

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go#newco...
src/pkg/bytes/bytes.go:14: // Compare returns an integer comparing the two byte
slices lexicographically.
(IMO, "the" is superfluous here.)

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go#newco...
src/pkg/bytes/bytes.go:56: // explode splits s into an slice of UTF-8 sequences,
one per Unicode character (still slices of bytes),
into a slice

[nigeltao, 2013-01-04 03:42:57]

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go
File src/pkg/bytes/bytes.go (right):

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go#newco...
src/pkg/bytes/bytes.go:14: // Compare returns an integer comparing the two byte
slices lexicographically.
On 2013/01/04 02:35:27, mdempsky wrote:
> (IMO, "the" is superfluous here.)

Done.

https://codereview.appspot.com/7028051/diff/4001/src/pkg/bytes/bytes.go#newco...
src/pkg/bytes/bytes.go:56: // explode splits s into an slice of UTF-8 sequences,
one per Unicode character (still slices of bytes),
On 2013/01/04 02:35:27, mdempsky wrote:
> into a slice

Done.

[dave_cheney.net, 2013-01-04 04:13:27]

LGTM.

https://codereview.appspot.com/7028051/diff/7001/src/pkg/bytes/bytes.go
File src/pkg/bytes/bytes.go (right):

https://codereview.appspot.com/7028051/diff/7001/src/pkg/bytes/bytes.go#newco...
src/pkg/bytes/bytes.go:336: // Join concatenates the elements of a to create a
new byte slice. The separator
a is a poor choice for a parameter name.

https://codereview.appspot.com/7028051/diff/7001/src/pkg/bytes/bytes_test.go
File src/pkg/bytes/bytes_test.go (right):

https://codereview.appspot.com/7028051/diff/7001/src/pkg/bytes/bytes_test.go#...
src/pkg/bytes/bytes_test.go:28: func sliceOfString(a [][]byte) []string {
s/a/s/

[mdempsky, 2013-01-04 21:38:49]

Perhaps better fixed in a followup CL, but I notice that Effective Go also
mentions "byte array" a few times when they're actually byte slices.  There's
also a reference to an "input array a" that isn't explicitly defined, but for
the code to compile "a" must be a slice.

[nigeltao, 2013-01-06 23:52:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=c9c7020ebc87 ***

bytes: fix docs: s/array/slice/.

R=rsc, mdempsky, dave
CC=golang-dev
https://codereview.appspot.com/7028051