code review 7024043: go/types: remove most remaining uses of ast.Object from...

go/types: remove most remaining uses of ast.Object from exported API

Also: Return first error whether an error handler is set in the
      context or not (bug fix).

[gri, 2012-12-28 23:13:15]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[adonovan, 2013-01-02 14:58:16]

LGTM

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/expr.go
File src/pkg/go/types/expr.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/expr.go#new...
src/pkg/go/types/expr.go:62: // keep the params list unchanged (this is the
externally visible type).
You already know my opinion that it would be easier for clients if we changed
the externally visible type too. :)

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/gcimporter.go
File src/pkg/go/types/gcimporter.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/gcimporter....
src/pkg/go/types/gcimporter.go:488: results = []*Var{{"", p.parseType()}}
So you're standardising on "" not "_" for anon receivers?

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/types.go
File src/pkg/go/types/types.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/types.go#ne...
src/pkg/go/types/types.go:214: Obj        *ast.Object // corresponding declared
object; Obj.Data.(*ast.Scope) contains methods, if any
Wanna add a TODO here to replace this with a canonical *Var?

[gri, 2013-01-02 17:18:40]

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/expr.go
File src/pkg/go/types/expr.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/expr.go#new...
src/pkg/go/types/expr.go:62: // keep the params list unchanged (this is the
externally visible type).
On 2013/01/02 14:58:16, adonovan wrote:
> You already know my opinion that it would be easier for clients if we changed
> the externally visible type too. :)
 We can revisit this later.

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/gcimporter.go
File src/pkg/go/types/gcimporter.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/gcimporter....
src/pkg/go/types/gcimporter.go:488: results = []*Var{{"", p.parseType()}}
On 2013/01/02 14:58:16, adonovan wrote:
> So you're standardising on "" not "_" for anon receivers?

it doesn't really matter - but i'll add a todo globally

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/types.go
File src/pkg/go/types/types.go (right):

https://codereview.appspot.com/7024043/diff/7001/src/pkg/go/types/types.go#ne...
src/pkg/go/types/types.go:214: Obj        *ast.Object // corresponding declared
object; Obj.Data.(*ast.Scope) contains methods, if any
On 2013/01/02 14:58:16, adonovan wrote:
> Wanna add a TODO here to replace this with a canonical *Var?

no need - there's a new CL in the works which does away with all ast.Objects and
uses types.Objects instead (and *Var).

[gri, 2013-01-02 17:29:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=92bc35448c34 ***

go/types: remove most remaining uses of ast.Object from exported API

Also: Return first error whether an error handler is set in the
      context or not (bug fix).

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7024043