Issue 70230049: Deprecated attributes upgrader

Issue 70230049: Deprecated attributes upgrader (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by wallyworld

Modified:
10 years, 3 months ago

Reviewers:
thumper, mp+208986

Visibility:
Public.

Description

Deprecated attributes upgrader Previous versions of Juju will have left deprecated attributes hanging around in the environment. This upgrader will remove such attributes from env state. eg default-image-id which is ignored will be put into env state. This upgrader removes it. Also, the deprecated attributes are no longer propagated when a new env config is made. https://code.launchpad.net/~wallyworld/juju-core/upgrade-remove-old-config/+merge/208986 Requires: https://code.launchpad.net/~axwalk/juju-core/upgrade-syslog-port/+merge/208724 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -16 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 chunk	+1 line, -1 line	1 comment	Download
M	cmd/jujud/unit.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	cmd/logging.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/logging_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/openstack/config.go	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	provider/openstack/config_test.go	View	3 chunks	+22 lines, -6 lines	0 comments	Download
A	upgrades/deprecatedattributes.go	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	upgrades/deprecatedattributes_test.go	View	1 chunk	+80 lines, -0 lines	3 comments	Download
M	upgrades/export_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	upgrades/steps118.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	upgrades/steps118_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	upgrades/systemsshkey_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thumper

LGTM - although not a fan of all the value asserts in the setup. https://codereview.appspot.com/70230049/diff/1/cmd/jujud/machine.go ...

10 years, 3 months ago (2014-03-04 03:04:57 UTC) #2

wallyworld

https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_test.go File upgrades/deprecatedattributes_test.go (right): https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_test.go#newcode46 upgrades/deprecatedattributes_test.go:46: c.Assert(allAttrs["public-bucket"], gc.Equals, "foo") On 2014/03/04 03:04:57, thumper wrote: > ...

10 years, 3 months ago (2014-03-04 03:09:56 UTC) #3

wallyworld

10 years, 3 months ago (2014-03-04 04:40:01 UTC) #4

https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_...
File upgrades/deprecatedattributes_test.go (right):

https://codereview.appspot.com/70230049/diff/1/upgrades/deprecatedattributes_...
upgrades/deprecatedattributes_test.go:46: c.Assert(allAttrs["public-bucket"],
gc.Equals, "foo")
On 2014/03/04 03:04:57, thumper wrote:
> Seems a lot to me to have the asserts in setup for this

I added an explicit test

Expand All Messages | Collapse All Messages