Issue 7018046: code review 7018046: exp/types: some comment fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7018046: code review 7018046: exp/types: some comment fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by gri

Modified:
12 years, 6 months ago

Reviewers:

CC:
adonovan, bradfitz, golang-dev

Visibility:
Public.

Description

exp/types: some comment fixes

Patch Set 1 #

Patch Set 2 : diff -r 2e40253cdd9b https://code.google.com/p/go #

Patch Set 3 : diff -r 2e40253cdd9b https://code.google.com/p/go #

Patch Set 4 : diff -r 2e40253cdd9b https://code.google.com/p/go #

Patch Set 5 : diff -r 2e40253cdd9b https://code.google.com/p/go #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
M	src/pkg/exp/gotype/gotype_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exp/types/expr.go	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 6 months ago (2012-12-26 21:54:34 UTC) #1

gri

12 years, 6 months ago (2012-12-26 22:04:55 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6aea29793585 ***

exp/types: some comment fixes

R=adonovan, bradfitz
CC=golang-dev
https://codereview.appspot.com/7018046

Expand All Messages | Collapse All Messages