Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 7013049: code review 7013049: go/types: moved from exp/types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by gri
Modified:
9 years, 6 months ago
Reviewers:
CC:
adonovan, golang-dev
Visibility:
Public.

Description

go/types: moved from exp/types This is a just a file move with no other changes besides the manual import path adjustments in these two files: src/pkg/exp/gotype/gotype.go src/pkg/exp/gotype/gotype_test.go Note: The go/types API continues to be subject to possibly significant changes until Go 1.1. Do not rely on it being stable at this point.

Patch Set 1 #

Patch Set 2 : diff -r d7f56af8557e https://code.google.com/p/go #

Patch Set 3 : diff -r d7f56af8557e https://code.google.com/p/go #

Patch Set 4 : diff -r d7f56af8557e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-30 lines, --30 lines) Patch
M src/pkg/exp/gotype/gotype.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/gotype/gotype_test.go View 1 2 2 chunks +1 line, -1 line 0 comments Download
M src/pkg/go/types/api.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/builtins.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/check.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/check_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/const.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/conversions.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/errors.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/exportdata.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/expr.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/gcimporter.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/gcimporter_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/operand.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/predicates.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/resolver_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/stmt.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/builtins.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/const0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/conversions.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/decls0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/decls1.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/decls2a.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/decls2b.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/decls3.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/exports.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/expr0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/expr1.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/expr2.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/expr3.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/testdata/stmt0.src View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/types.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/types_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/go/types/universe.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-28 19:05:33 UTC) #1
adonovan
The code change looks good. :) I'm not sure I have the power to approve ...
9 years, 6 months ago (2012-12-28 19:20:19 UTC) #2
adonovan
LGTM
9 years, 6 months ago (2012-12-28 19:39:33 UTC) #3
gri
9 years, 6 months ago (2012-12-28 19:41:53 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=8ea98ec93704 ***

go/types: moved from exp/types

This is a just a file move with no other changes
besides the manual import path adjustments in these
two files:

src/pkg/exp/gotype/gotype.go
src/pkg/exp/gotype/gotype_test.go

Note: The go/types API continues to be subject to
possibly significant changes until Go 1.1. Do not
rely on it being stable at this point.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/7013049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b