Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1228)

Issue 7011048: Make angle compile on Win64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by jschuh
Modified:
11 years, 4 months ago
Reviewers:
dgkoch, nicolas, apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make angle compile on Win64 BUG=http://crbug.com/166496 BUG=http://crbug.com/167187

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/build_angle.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
jschuh
11 years, 4 months ago (2012-12-27 07:18:56 UTC) #1
apatrick1
LGTM. Do you need me to commit it?
11 years, 4 months ago (2013-01-02 19:14:20 UTC) #2
jschuh
On 2013/01/02 19:14:20, apatrick1 wrote: > LGTM. Do you need me to commit it? Yeah, ...
11 years, 4 months ago (2013-01-02 19:19:01 UTC) #3
nicolas
On 2013/01/02 19:14:20, apatrick1 wrote: > LGTM. Do you need me to commit it? C4267 ...
11 years, 4 months ago (2013-01-02 19:21:22 UTC) #4
dgkoch
On 2013/01/02 19:21:22, nicolas wrote: > On 2013/01/02 19:14:20, apatrick1 wrote: > > LGTM. Do ...
11 years, 4 months ago (2013-01-02 19:22:45 UTC) #5
jschuh
On 2013/01/02 19:21:22, nicolas wrote: > On 2013/01/02 19:14:20, apatrick1 wrote: > > LGTM. Do ...
11 years, 4 months ago (2013-01-02 19:23:19 UTC) #6
apatrick1
11 years, 4 months ago (2013-01-02 20:35:09 UTC) #7
I filed a bug to fix the underlying warnings.
http://code.google.com/p/angleproject/issues/detail?id=391
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b