Issue 7011048: Make angle compile on Win64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7011048: Make angle compile on Win64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by jschuh

Modified:
11 years, 10 months ago

Reviewers:
dgkoch, nicolas, apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Make angle compile on Win64 BUG=http://crbug.com/166496 BUG=http://crbug.com/167187

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/build_angle.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7

jschuh

On 2013/01/02 19:14:20, apatrick1 wrote: > LGTM. Do you need me to commit it? Yeah, ...

11 years, 10 months ago (2013-01-02 19:19:01 UTC) #3

nicolas

On 2013/01/02 19:14:20, apatrick1 wrote: > LGTM. Do you need me to commit it? C4267 ...

11 years, 10 months ago (2013-01-02 19:21:22 UTC) #4

dgkoch

On 2013/01/02 19:21:22, nicolas wrote: > On 2013/01/02 19:14:20, apatrick1 wrote: > > LGTM. Do ...

11 years, 10 months ago (2013-01-02 19:22:45 UTC) #5

jschuh

On 2013/01/02 19:21:22, nicolas wrote: > On 2013/01/02 19:14:20, apatrick1 wrote: > > LGTM. Do ...

11 years, 10 months ago (2013-01-02 19:23:19 UTC) #6

apatrick1

11 years, 10 months ago (2013-01-02 20:35:09 UTC) #7

I filed a bug to fix the underlying warnings.
http://code.google.com/p/angleproject/issues/detail?id=391