Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(177)

Issue 7011047: code review 7011047: io/ioutil: fix Discard data race (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by bradfitz
Modified:
4 years, 9 months ago
Reviewers:
CC:
golang-dev, iant, dvyukov
Visibility:
Public.

Description

io/ioutil: fix Discard data race Fixes issue 4589

Patch Set 1 #

Patch Set 2 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b07c0f6d6b5f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M src/pkg/io/ioutil/blackhole.go View 1 1 chunk +14 lines, -4 lines 0 comments Download
R src/pkg/io/ioutil/blackhole_race.go View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/pkg/io/ioutil/ioutil.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 10 months ago (2012-12-26 21:03:27 UTC) #1
iant
LGTM
4 years, 10 months ago (2012-12-27 00:12:34 UTC) #2
dvyukov
LGTM
4 years, 9 months ago (2012-12-28 10:30:29 UTC) #3
bradfitz
4 years, 9 months ago (2012-12-28 17:33:28 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=4b61f121966b ***

io/ioutil: fix Discard data race

Fixes issue 4589

R=golang-dev, iant, dvyukov
CC=golang-dev
https://codereview.appspot.com/7011047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted