Issue 70080047: code review 70080047: syscall: regenerate z-files for dragonfly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 70080047: code review 70080047: syscall: regenerate z-files for dragonfly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by jsing

Modified:
11 years ago

Reviewers:
gobot, mikio

CC:
golang-codereviews, mikio

Visibility:
Public.

Description

syscall: regenerate z-files for dragonfly Regenerate z-files for DragonFly BSD 3.6. F_DUP_FD_CLOEXEC is now supported, so remove the zero value constant from types_dragonfly.go so that we use the generated value from the z-files.

Patch Set 1 : diff -r 4cd83f2e218e https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 4cd83f2e218e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3fd2a230723b https://go.googlecode.com/hg/ #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -20 lines)			Patch
M	src/pkg/syscall/types_dragonfly.go	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/zerrors_dragonfly_386.go	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_dragonfly_amd64.go	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zsysnum_dragonfly_386.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsysnum_dragonfly_amd64.go	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/ztypes_dragonfly_386.go	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/ztypes_dragonfly_amd64.go	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jsing

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years ago (2014-03-05 12:46:24 UTC) #1

jsing

*** Submitted as https://code.google.com/p/go/source/detail?r=1a0714819799 *** syscall: regenerate z-files for dragonfly Regenerate z-files for DragonFly BSD ...

11 years ago (2014-03-05 13:09:17 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the windows-386-ec2 builder.

Expand All Messages | Collapse All Messages