Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 7007047: Add user login support.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by benji
Modified:
7 years, 9 months ago
Reviewers:
mp+141133
Visibility:
Public.

Description

Add user login support. Future work: we need to implement a real UI for this. At the moment this branch uses prompt() calls to generate modal dialogs. Also, this will probably need slight tweaking once the backend actually requires authorization. https://code.launchpad.net/~benji/juju-gui/login/+merge/141133 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 15

Patch Set 2 : Add user login support. #

Patch Set 3 : Add user login support. #

Patch Set 4 : Add user login support. #

Total comments: 7

Patch Set 5 : Add user login support. #

Patch Set 6 : Add user login support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -32 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 3 4 5 chunks +49 lines, -0 lines 0 comments Download
M app/modules-debug.js View 2 chunks +5 lines, -0 lines 0 comments Download
M app/modules-prod.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/store/env.js View 1 2 3 4 6 chunks +49 lines, -7 lines 0 comments Download
A app/views/login.js View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M test/index.html View 1 2 3 4 3 chunks +26 lines, -22 lines 0 comments Download
M test/test_app.js View 1 4 chunks +7 lines, -1 line 0 comments Download
M test/test_app_hotkeys.js View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A test/test_login.js View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M test/test_service_view.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13
benji
Please take a look.
7 years, 10 months ago (2012-12-21 20:53:42 UTC) #1
hazmat
needs work https://codereview.appspot.com/7007047/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7007047/diff/1/app/app.js#newcode544 app/app.js:544: if (!view.waiting && !view.userIsAuthenticated) { this content ...
7 years, 10 months ago (2012-12-21 21:06:18 UTC) #2
bac
This looks ok to me, given the changes Kapil requests. I'll look again after those ...
7 years, 10 months ago (2013-01-02 14:45:03 UTC) #3
benji
Please take a look. https://codereview.appspot.com/7007047/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/7007047/diff/1/app/app.js#newcode530 app/app.js:530: * @param {Object} res ??? ...
7 years, 10 months ago (2013-01-02 20:43:28 UTC) #4
benji
I have addressed all the comments (some with further questions) and pushed the changes.
7 years, 10 months ago (2013-01-02 20:44:45 UTC) #5
hazmat
On Wed, Jan 2, 2013 at 2:43 PM, <benji.york@gmail.com> wrote: > Please take a look. ...
7 years, 10 months ago (2013-01-02 21:09:52 UTC) #6
benji
Please take a look.
7 years, 10 months ago (2013-01-02 21:25:49 UTC) #7
benji
Please take a look.
7 years, 9 months ago (2013-01-07 20:14:39 UTC) #8
gary.poster
If you want me to look at this again I would be happy to, but ...
7 years, 9 months ago (2013-01-07 20:59:59 UTC) #9
gary.poster
Please make a high priority card for the UI implementation, btw
7 years, 9 months ago (2013-01-07 21:02:04 UTC) #10
benji
Please take a look. https://codereview.appspot.com/7007047/diff/15001/app/store/env.js File app/store/env.js (right): https://codereview.appspot.com/7007047/diff/15001/app/store/env.js#newcode113 app/store/env.js:113: } On 2013/01/07 20:59:59, gary.poster ...
7 years, 9 months ago (2013-01-07 21:39:26 UTC) #11
benji
Thanks for the review. I have addressed each comment and created a "make better UI" ...
7 years, 9 months ago (2013-01-07 21:39:36 UTC) #12
benji
7 years, 9 months ago (2013-01-08 13:47:36 UTC) #13
*** Submitted:

Add user login support.

Future work: we need to implement a real UI for this.  At the moment this
branch uses prompt() calls to generate modal dialogs.  Also, this will
probably need slight tweaking once the backend actually requires
authorization.

R=hazmat, bac, gary.poster
CC=
https://codereview.appspot.com/7007047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b