Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6837)

Issue 7005056: Measure 'staff-padding' to reference points, as claimed in its docstring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Keith
Modified:
10 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

five commits Measure 'staff-padding' to reference points; issue 3026 lily/side-position-interface.cc | 6 +++--- scm/define-grobs.scm | 4 ++-- DynamicText: reference point at middle of ex-height scm/define-grobs.scm | 3 +-- scm/output-lib.scm | 5 +++++ Doc: update staff-padding Documentation/learning/tweaks.itely | 20 +- Documentation/notation/keyboards.itely | 2 +- Documentation/notation/spacing.itely | 6 +- .../snippets/new/broken-crescendo-hairpin.ly | 42 +++ Documentation/snippets/new/expressive-headword.ly | 268 ++++++++++++++++++++ Documentation/snippets/new/pitches-headword.ly | 137 ++++++++++ .../vertically-aligned-dynamics-and-textscripts.ly | 34 +++ 7 files changed, 493 insertions(+), 16 deletions(-) makelsr Documentation/snippets/broken-crescendo-hairpin.ly | 47 ++++++++------------ Documentation/snippets/expressive-headword.ly | 17 ++++--- Documentation/snippets/pitches-headword.ly | 22 +++++----- .../vertically-aligned-dynamics-and-textscripts.ly | 30 ++++++------ convert-ly rule python/convertrules.py | 8 ++++++++

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : center dynamic p and f, update docs #

Total comments: 2

Patch Set 7 : update snippets, makelsr #

Patch Set 8 : remove extra % begin verbatim #

Patch Set 9 : remakelsr #

Total comments: 2

Patch Set 10 : untypo typos #

Patch Set 11 : add convert-ly rule #

Patch Set 12 : reword convert message #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -86 lines) Patch
M Documentation/learning/tweaks.itely View 1 2 3 4 5 6 7 8 9 10 3 chunks +8 lines, -12 lines 1 comment Download
M Documentation/notation/keyboards.itely View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/spacing.itely View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/broken-crescendo-hairpin.ly View 1 2 3 4 5 6 7 8 9 4 chunks +18 lines, -29 lines 0 comments Download
M Documentation/snippets/expressive-headword.ly View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -8 lines 0 comments Download
A Documentation/snippets/new/broken-crescendo-hairpin.ly View 1 2 3 4 5 6 7 8 9 1 chunk +42 lines, -0 lines 0 comments Download
A Documentation/snippets/new/expressive-headword.ly View 1 2 3 4 5 6 7 8 1 chunk +268 lines, -0 lines 0 comments Download
A Documentation/snippets/new/pitches-headword.ly View 1 2 3 4 5 6 7 8 1 chunk +137 lines, -0 lines 0 comments Download
A Documentation/snippets/new/vertically-aligned-dynamics-and-textscripts.ly View 1 2 3 4 5 6 7 8 1 chunk +34 lines, -0 lines 0 comments Download
M Documentation/snippets/pitches-headword.ly View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -11 lines 0 comments Download
M Documentation/snippets/vertically-aligned-dynamics-and-textscripts.ly View 1 2 3 4 5 6 7 8 2 chunks +15 lines, -15 lines 0 comments Download
M lily/side-position-interface.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M python/convertrules.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +8 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +3 lines, -4 lines 0 comments Download
M scm/output-lib.scm View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Keith
DynamicText is shifted to that the center of the 'm' in "mf" is at the ...
10 years, 7 months ago (2013-09-06 03:02:11 UTC) #1
lemzwerg
LGTM. https://codereview.appspot.com/7005056/diff/29001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (left): https://codereview.appspot.com/7005056/diff/29001/Documentation/notation/spacing.itely#oldcode2048 Documentation/notation/spacing.itely:2048: << s/midlne/midline/
10 years, 7 months ago (2013-09-06 05:01:03 UTC) #2
Trevor Daniels
A couple of typos. I can't give a LGTM as I haven't recompiled to check ...
10 years, 7 months ago (2013-09-07 10:06:25 UTC) #3
Mark Polesky
https://codereview.appspot.com/7005056/diff/35015/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/7005056/diff/35015/Documentation/learning/tweaks.itely#newcode2987 Documentation/learning/tweaks.itely:2987: \override DynamicLineSpanner.staff-padding = #3 I think we should stop ...
10 years, 7 months ago (2013-09-18 23:45:37 UTC) #4
Keith
10 years, 7 months ago (2013-09-19 05:26:52 UTC) #5
On 2013/09/18 23:45:37, Mark Polesky wrote:

> I think we should stop using the `#' for scheme numbers.

But when it is time to make that change, we would make the change over all the
documentation at once.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b