code review 7004053: net: consolidate fd_{free,net,open}bsd.go into fd_bsd.go

net: consolidate fd_{free,net,open}bsd.go into fd_bsd.go

These files are identical, so probably pre date // +build.

With a little work, fd_darwin could be merged as well.

[dave_cheney.net, 2012-12-23 03:57:23]

Hello mikioh.mikioh@gmail.com, jsing@google.com, devon.odell@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2012-12-23 03:57:55]

% sha1sum fd_{free,net,open}bsd.go
9f2665109c567f1c91ef0f141b98558e77451deb  fd_freebsd.go
9f2665109c567f1c91ef0f141b98558e77451deb  fd_netbsd.go
9f2665109c567f1c91ef0f141b98558e77451deb  fd_openbsd.go

[lucio, 2012-12-23 06:20:03]

On 12/23/12, dave@cheney.net <dave@cheney.net> wrote:
> % sha1sum fd_{free,net,open}bsd.go
> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_freebsd.go
> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_netbsd.go
> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_openbsd.go
>
>
> https://codereview.appspot.com/7004053/
>

[lucio, 2012-12-23 06:20:37]

Oops, I'm sorry!  (and compounding the mischief!)

Lucio.


On 12/23/12, Lucio De Re <lucio.dere@gmail.com> wrote:
> On 12/23/12, dave@cheney.net <dave@cheney.net> wrote:
>> % sha1sum fd_{free,net,open}bsd.go
>> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_freebsd.go
>> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_netbsd.go
>> 9f2665109c567f1c91ef0f141b98558e77451deb  fd_openbsd.go
>>
>>
>> https://codereview.appspot.com/7004053/
>>
>

[mikio, 2012-12-26 03:16:10]

LGTM

[dave_cheney.net, 2012-12-27 09:58:59]

On 2012/12/26 03:16:10, mikio wrote:
> LGTM

Thanks. Anyone from the netbsd/openbsd camps have any objections ?

[minux1, 2012-12-27 13:18:09]

LGTM for NetBSD.

[jsing, 2012-12-27 13:24:51]

LGTM

I do not believe that they will diverge any time soon and if they do we can
always split them out again.

[dave_cheney.net, 2012-12-27 13:27:22]

Thanks folks, will look at committing this tomorrow, then I'll see if the
Darwin variant can be merged.
On 28 Dec 2012 00:24, <jsing@google.com> wrote:

> LGTM
>
> I do not believe that they will diverge any time soon and if they do we
> can always split them out again.
>
>
https://codereview.appspot.**com/7004053/<https://codereview.appspot.com/7004...
>

[dave_cheney.net, 2012-12-28 10:02:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=6496931a5a26 ***

net: consolidate fd_{free,net,open}bsd.go into fd_bsd.go

These files are identical, so probably pre date // +build.

With a little work, fd_darwin could be merged as well.

R=mikioh.mikioh, jsing, devon.odell, lucio.dere, minux.ma
CC=golang-dev
https://codereview.appspot.com/7004053