Issue 7003050: cmd: renaming, aliasing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7003050: cmd: renaming, aliasing

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by fwereade

Modified:
11 years, 4 months ago

Reviewers:
dimitern, mp+141157, rog

Visibility:
Public.

Description

cmd: renaming, aliasing SuperCommand.Register now takes (subcmd Command, aliases ...string); both remove-unit and remove-relation have been renamed to destroy-, and the old names are aliased to the new ones. https://code.launchpad.net/~fwereade/juju-core/cmd-aliases/+merge/141157 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : cmd: renaming, aliasing #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -44 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	cmd/juju/destroyrelation.go	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	cmd/juju/destroyrelation_test.go	View		2 chunks	+11 lines, -11 lines	0 comments	Download
M	cmd/juju/destroyunit.go	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	cmd/juju/destroyunit_test.go	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	cmd/juju/main.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/main_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/supercommand.go	View		2 chunks	+20 lines, -2 lines	0 comments	Download
M	cmd/supercommand_test.go	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM (even without the suggestion). https://codereview.appspot.com/7003050/diff/1/cmd/juju/cmd_test.go File cmd/juju/cmd_test.go (right): https://codereview.appspot.com/7003050/diff/1/cmd/juju/cmd_test.go#newcode364 cmd/juju/cmd_test.go:364: c.Assert(err, ErrorMatches, "invalid service ...

11 years, 4 months ago (2013-01-03 22:13:05 UTC) #2

fwereade

11 years, 4 months ago (2013-01-07 13:11:52 UTC) #4

*** Submitted:

cmd: renaming, aliasing

SuperCommand.Register now takes (subcmd Command, aliases ...string); both
remove-unit and remove-relation have been renamed to destroy-, and the old
names are aliased to the new ones.

R=dimitern, rog
CC=
https://codereview.appspot.com/7003050

Expand All Messages | Collapse All Messages