Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)

Issue 7002051: code review 7002051: undo CL 6938073 / 1542912cf09d (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rsc
Modified:
12 years, 5 months ago
Reviewers:
CC:
ken2, golang-dev
Visibility:
Public.

Description

undo CL 6938073 / 1542912cf09d remove zerostack compiler experiment; will do at link time instead ««« original CL description cmd/gc: add GOEXPERIMENT=zerostack to clear stack on function entry This is expensive but it might be useful in cases where people are suffering from false positives during garbage collection and are willing to trade the CPU time for getting rid of the false positives. On the other hand it only eliminates false positives caused by other function calls, not false positives caused by dead temporaries stored in the current function call. The 5g/6g/8g changes were pulled out of the history, from the last time we needed to do this (to work around a goto bug). The code in go.h, lex.c, pgen.c is new but tiny. R=ken2 CC=golang-dev https://codereview.appspot.com/6938073 »»»

Patch Set 1 #

Patch Set 2 : diff -r 2414f5fb898d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -140 lines) Patch
M src/cmd/5g/gsubr.c View 1 1 chunk +0 lines, -58 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 1 chunk +0 lines, -38 lines 0 comments Download
M src/cmd/8g/gsubr.c View 1 1 chunk +0 lines, -38 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/cmd/gc/lex.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/pgen.c View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
12 years, 5 months ago (2012-12-22 16:17:59 UTC) #1
rsc
12 years, 5 months ago (2012-12-22 16:18:07 UTC) #2
*** Submitted as https://code.google.com/p/go/source/detail?r=4f231e209b4c ***

undo CL 6938073 / 1542912cf09d

remove zerostack compiler experiment; will do at link time instead

««« original CL description
cmd/gc: add GOEXPERIMENT=zerostack to clear stack on function entry

This is expensive but it might be useful in cases where
people are suffering from false positives during garbage
collection and are willing to trade the CPU time for getting
rid of the false positives.

On the other hand it only eliminates false positives caused
by other function calls, not false positives caused by dead
temporaries stored in the current function call.

The 5g/6g/8g changes were pulled out of the history, from
the last time we needed to do this (to work around a goto bug).
The code in go.h, lex.c, pgen.c is new but tiny.

R=ken2
CC=golang-dev
https://codereview.appspot.com/6938073
»»»

R=ken2
CC=golang-dev
https://codereview.appspot.com/7002051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b