Issue 7001053: juju: stream charm data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7001053: juju: stream charm data

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by fwereade

Modified:
11 years, 3 months ago

Reviewers:
dimitern, mp+141167, jameinel, rog

Visibility:
Public.

Description

juju: stream charm data fixes lp:1017733 https://code.launchpad.net/~fwereade/juju-core/deploy-large-charms/+merge/141167 (do not edit description out of merge proposal)

Patch Set 2 : juju: stream charm data #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -13 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	juju/conn.go	View	1	2 chunks	+30 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

On 2012/12/22 21:24:15, fwereade wrote: > Please take a look. LGTM

11 years, 3 months ago (2013-01-03 22:05:30 UTC) #2

jameinel

It would be nice if you re-used the already open file, rather than closing and ...

11 years, 3 months ago (2013-01-06 10:23:39 UTC) #3

rog

i agree with jameinel's comment, otherwise LGTM to me too. https://codereview.appspot.com/7001053/diff/1/juju/conn.go File juju/conn.go (right): https://codereview.appspot.com/7001053/diff/1/juju/conn.go#newcode195 ...

11 years, 3 months ago (2013-01-07 08:51:17 UTC) #4

fwereade

11 years, 3 months ago (2013-01-07 09:08:05 UTC) #5

*** Submitted:

juju: stream charm data

fixes lp:1017733

R=dimitern, jameinel, rog
CC=
https://codereview.appspot.com/7001053

https://codereview.appspot.com/7001053/diff/1/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/7001053/diff/1/juju/conn.go#newcode195
juju/conn.go:195: f.Close()
On 2013/01/06 10:23:39, jameinel wrote:
> It seems a little odd to create the file, only to close it and re-open it.
Would
> it make more sense to share the 'f' variable, and move the Open code only into
> the *charm.Bundle section?

Yeah, much nicer, thanks.

Expand All Messages | Collapse All Messages