Add tests for panzoom.

Add tests for panzoom.

Tests are added for panzoom.  Due to agreed upon time-boxing, the testing is
not thorough but is a start.  Another bug to complete the testing will be
filed.

https://code.launchpad.net/~bac/juju-gui/1083935/+merge/141135

(do not edit description out of merge proposal)

[bac, 2012-12-21 21:24:04]

Please take a look.

[matthew.scott, 2012-12-21 21:37:23]

Looks good, few minors, land otherwise.

In the past, we've been taking mocha's style pretty seriously and treating the
it function as the first word in a sentence.  I know that we may be changing
testing frameworks soon, so it's up to you, but it might be more readable to
continue that with this package of tests (i.e.: it('should set initial
values').)  It's a minor naming thing, and I'm not too hung up on it, so if
everyone else is cool with it, so am I :)

[gary.poster, 2012-12-21 22:37:54]

Land with changes.

Hey Brad.  Thank you.  Looks good.

Actually, unrelated to your work, but new branches are broken right now because
of the new d3.  Could you change packages.json to specify d3 in this way?

"d3": "2.10.x"

I agree with Matt that it would be nice if you tried to make a sentence with
"it."  I also agree that I'm kinda low on caring.

I wish you didn't have to redefine Y, but I'm guessing you did it for a reason. 
Please at least try to change the async: false approach that Kapil suggests for
the "before" Y, and then delete the "beforeEach" version, and see if that works.
 If not, land it.

Thanks

Gary

https://codereview.appspot.com/7001047/diff/1/test/test_panzoom.js
File test/test_panzoom.js (right):

https://codereview.appspot.com/7001047/diff/1/test/test_panzoom.js#newcode23
test/test_panzoom.js:23: Y = YUI(GlobalConfig).use(['node',
Why can't you just use the Y from before?  This is a pattern I have not seen
before in our tests.

[bac, 2013-01-02 12:38:41]

I'd just read this post by jml and thought I'd put it in practice, neglecting
the inherited style:

https://plus.google.com/115348217455779620753/posts/YA3ThKWhSAj

I've made the changes you request but perhaps we can bear this in mind if we do
change testing infrastructures so our descriptions can be more precise.

[bac, 2013-01-02 12:56:35]

The changes suggested by Matt and Gary have been incorporated, except for the
'async': false suggestion.  I found removing the async in beforeEach() was
unnecessary but it was required in before() regardless of setting async:false. 
Perhaps I have missed something.  Will clarify before landing.

https://codereview.appspot.com/7001047/diff/1/test/test_panzoom.js
File test/test_panzoom.js (right):

https://codereview.appspot.com/7001047/diff/1/test/test_panzoom.js#newcode23
test/test_panzoom.js:23: Y = YUI(GlobalConfig).use(['node',
This was just plain dumb and has been removed.

[bac, 2013-01-02 13:02:29]

Please take a look.

[gary.poster, 2013-01-02 13:05:00]

Hey Brad.  I'm out today as planned vacation, and I'm also unfortunately sick
with fever. If you need another look from someone please ask around

Gary

On Jan 2, 2013, at 8:02 AM, bac@canonical.com wrote:

> Please take a look.
> 
> https://codereview.appspot.com/7001047/

[bac, 2013-01-02 13:08:41]

*** Submitted:

Add tests for panzoom.

Tests are added for panzoom.  Due to agreed upon time-boxing, the testing is
not thorough but is a start.  Another bug to complete the testing will be
filed.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7001047