Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 7000046: Ensure GYP_PARALLEL prints error messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dmazzoni
Modified:
11 years, 3 months ago
Reviewers:
thakis, scottmg
Base URL:
http://gyp.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Ensure GYP_PARALLEL prints error messages. Errors sent to stdout were being swallowed by gclient runhooks; moved them to stderr. Also added an informational message when there's an error, and made it so that GYP_PARALLEL=0 disables parallel processing. After this change, we should be able to turn parallel on by default. BUG=154205

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed extra warning #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M pylib/gyp/__init__.py View 1 chunk +2 lines, -1 line 0 comments Download
M pylib/gyp/input.py View 1 3 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 7
dmazzoni
11 years, 4 months ago (2012-12-21 19:43:48 UTC) #1
thakis
https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py#newcode2564 pylib/gyp/input.py:2564: 'To disable, set GYP_PARALLEL=0 in your environment.') Is this ...
11 years, 4 months ago (2012-12-21 19:45:53 UTC) #2
dmazzoni
https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py#newcode2564 pylib/gyp/input.py:2564: 'To disable, set GYP_PARALLEL=0 in your environment.') On 2012/12/21 ...
11 years, 4 months ago (2012-12-21 19:51:55 UTC) #3
thakis
https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.appspot.com/7000046/diff/1/pylib/gyp/input.py#newcode2564 pylib/gyp/input.py:2564: 'To disable, set GYP_PARALLEL=0 in your environment.') On 2012/12/21 ...
11 years, 4 months ago (2012-12-21 19:53:55 UTC) #4
dmazzoni
On 2012/12/21 19:53:55, thakis wrote: > If something breaks, the error output above will contain ...
11 years, 4 months ago (2012-12-21 19:55:46 UTC) #5
thakis
lgtm On 2012/12/21 19:55:46, dmazzoni wrote: > On 2012/12/21 19:53:55, thakis wrote: > > If ...
11 years, 4 months ago (2012-12-21 20:05:08 UTC) #6
scottmg
11 years, 4 months ago (2012-12-22 04:04:37 UTC) #7
https://codereview.appspot.com/7000046/diff/5001/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://codereview.appspot.com/7000046/diff/5001/pylib/gyp/input.py#newcode576
pylib/gyp/input.py:576: 'If the error only occurs when GYP_PARELLEL=1, '
if you don't remove it, PARELLEL->PARALLEL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b