Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 6999047: Relations Topology Module

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by matthew.scott
Modified:
7 years, 9 months ago
Reviewers:
mp+141120, bcsaller
Visibility:
Public.

Description

Relations Topology Module Refactoring relations out of the mega topology module into its own module. This is quite a big branch, and with undocumented methods and custom events, may get larger yet. Requesting bcsaller as one reviewer. https://code.launchpad.net/~makyo/juju-gui/topology-relations/+merge/141120 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Relations Topology Module #

Total comments: 7

Patch Set 3 : Relations Topology Module #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1017 lines, -910 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/d3-components.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/views/environment.js View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/topology/mega.js View 1 2 23 chunks +79 lines, -773 lines 0 comments Download
M app/views/topology/relation.js View 1 2 3 chunks +781 lines, -1 line 0 comments Download
M app/views/topology/topology.js View 1 chunk +9 lines, -0 lines 0 comments Download
M test/test_application_notifications.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M test/test_environment_view.js View 4 chunks +12 lines, -9 lines 0 comments Download
M undocumented View 1 7 chunks +128 lines, -123 lines 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
7 years, 10 months ago (2012-12-21 19:34:33 UTC) #1
matthew.scott
Please take a look.
7 years, 10 months ago (2012-12-21 21:31:57 UTC) #2
bcsaller
LGTM, with the notes below. I'd suggest moving to single event fires where indicated below. ...
7 years, 10 months ago (2013-01-02 21:53:07 UTC) #3
bac
Looks good Matt. https://codereview.appspot.com/6999047/diff/3001/app/views/topology/mega.js File app/views/topology/mega.js (right): https://codereview.appspot.com/6999047/diff/3001/app/views/topology/mega.js#newcode37 app/views/topology/mega.js:37: //mouseleave: 'mousemove' Delete commented out code.
7 years, 9 months ago (2013-01-03 14:10:37 UTC) #4
matthew.scott
Thanks for the reviews. Discovered https://bugs.launchpad.net/juju-gui/+bug/1095761 in the process, which was causing my regression. Will ...
7 years, 9 months ago (2013-01-03 20:44:16 UTC) #5
matthew.scott
7 years, 9 months ago (2013-01-03 20:48:55 UTC) #6
*** Submitted:

Relations Topology Module

Refactoring relations out of the mega topology module into its own module.  This
is quite a big branch, and with undocumented methods and custom events, may get
larger yet.  Requesting bcsaller as one reviewer.

R=
CC=
https://codereview.appspot.com/6999047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b