Issue 69980054: Make the proof API check constraints.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69980054: Make the proof API check constraints.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by bac

Modified:
10 years, 1 month ago

Reviewers:
mp+209741, matthew.scott

Visibility:
Public.

Description

Make the proof API check constraints. The proof API now uses charmworldlib to check the charm constraints specified in a bundle (deployer file). Errors returned from parse_constraints are returned as errors. If check_constraints indicates the constraints are comma-separated then a deprecation warning is returned. The previous API did not allow for warnings, so that mechanism was added. There are a lot of drive-by cleanups too, mainly in the test. Sorry for the noise they introduce but I think the code is more consistent and the tests are improved. https://code.launchpad.net/~bac/charmworld/check-constraints-commas/+merge/209741 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+354 lines, -212 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/lib/proof.py	View		2 chunks	+6 lines, -9 lines	0 comments	Download
M	charmworld/views/api/__init__.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	charmworld/views/api/proof.py	View	1	11 chunks	+99 lines, -42 lines	0 comments	Download
M	charmworld/views/tests/test_api.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	charmworld/views/tests/test_bundles.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	charmworld/views/tests/test_proof.py	View		15 chunks	+242 lines, -156 lines	0 comments	Download
M	requirements.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Code LGTM - thanks for the test cleanups.

Expand All Messages | Collapse All Messages