Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 6997052: code review 6997052: runtime: less aggressive per-thread stack segment caching (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dvyukov
Modified:
9 years, 5 months ago
Reviewers:
CC:
msolomon
Visibility:
Public.

Description

runtime: less aggressive per-thread stack segment caching Introduce global stack segment cache and limit per-thread cache size. This greatly reduces StackSys memory on workloads that create lots of threads. TestStackMem old,MB old,sec new,MB new,sec Run #1 310 3.22 8 1.83 Run #2 296 2.43 8 1.84 Run #3 479 2.50 8 1.88 Run #4 264 2.46 8 1.82 Run #5 296 2.53 8 2.00

Patch Set 1 #

Patch Set 2 : diff -r f4e5087c1c19 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r f4e5087c1c19 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r b07c0f6d6b5f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r b07c0f6d6b5f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r b07c0f6d6b5f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r b07c0f6d6b5f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r 019884311591 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -3 lines) Patch
M src/pkg/runtime/malloc.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/malloc.goc View 1 2 3 4 3 chunks +51 lines, -0 lines 0 comments Download
M src/pkg/runtime/mfixalloc.c View 1 4 chunks +5 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/proc_test.go View 1 2 3 4 5 6 7 3 chunks +10 lines, -2 lines 0 comments Download
M src/pkg/runtime/stack.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/stack_test.go View 1 2 3 4 5 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 13
dvyukov
Hello golang-dev@googlegroups.com (cc: msolomon@google.com, sougou@google.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 6 months ago (2012-12-28 17:58:13 UTC) #1
sougou
vtocc test run on 10M queries using 100 connections: Old runtime StackSys started at 26MB ...
9 years, 6 months ago (2012-12-28 19:52:11 UTC) #2
dvyukov
On 2012/12/28 19:52:11, sougou wrote: > vtocc test run on 10M queries using 100 connections: ...
9 years, 6 months ago (2012-12-28 20:34:08 UTC) #3
sougou
I saw a 10% drop in throughput compared to a build from October (5.5k vs ...
9 years, 6 months ago (2012-12-28 20:59:30 UTC) #4
dvyukov
If you see some performance degradation try to tune StackPerThreadLWM/StackPerThreadHWM (to say 64/128). On Sat, ...
9 years, 6 months ago (2012-12-28 21:04:01 UTC) #5
nsf
On 2012/12/28 17:58:13, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:msolomon@google.com, mailto:sougou@google.com), > > I'd like ...
9 years, 6 months ago (2012-12-29 13:00:52 UTC) #6
dvyukov
On 2012/12/29 13:00:52, nsf wrote: > On 2012/12/28 17:58:13, dvyukov wrote: > > Hello mailto:golang-dev@googlegroups.com ...
9 years, 6 months ago (2012-12-29 13:17:21 UTC) #7
dvyukov
I've added the benchmark, BenchmarkStackGrowthDeep, that growth and shrinks stack in multiple goroutines. There is ...
9 years, 6 months ago (2012-12-29 20:08:51 UTC) #8
remyoudompheng
On 2012/12/29 <dvyukov@google.com> wrote: > I've added the benchmark, BenchmarkStackGrowthDeep, that growth and > shrinks ...
9 years, 6 months ago (2012-12-29 20:34:19 UTC) #9
dvyukov
On Sun, Dec 30, 2012 at 12:34 AM, Rémy Oudompheng <remyoudompheng@gmail.com> wrote: > On 2012/12/29 ...
9 years, 6 months ago (2012-12-29 20:40:03 UTC) #10
dvyukov
On 2012/12/29 20:40:03, dvyukov wrote: > On Sun, Dec 30, 2012 at 12:34 AM, Rémy ...
9 years, 6 months ago (2012-12-30 18:08:27 UTC) #11
dvyukov
On 2012/12/30 18:08:27, dvyukov wrote: > On 2012/12/29 20:40:03, dvyukov wrote: > > On Sun, ...
9 years, 6 months ago (2013-01-03 17:43:48 UTC) #12
rsc
9 years, 5 months ago (2013-01-18 19:23:42 UTC) #13
Message was sent while issue was closed.
removing reviewers
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b