Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 6997049: code review 6997049: runtime/linux: die more gracefully when locked mem quot...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Sebastien Paolacci
Modified:
8 years, 5 months ago
Reviewers:
minux1, rsc, dfc
CC:
golang-codereviews
Visibility:
Public.

Description

runtime/linux: die more gracefully when locked mem quota is overrun. Used to then die on a nil pointer situation. Most Linux standard setups are rather restrictive regarding the default amount of lockable memory.

Patch Set 1 #

Patch Set 2 : diff -r 1fd839e10187 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1fd839e10187 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 1fd839e10187 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/pkg/runtime/mem_linux.c View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Sebastien Paolacci
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2012-12-23 10:16:12 UTC) #1
minux1
https://codereview.appspot.com/6997049/diff/2002/src/pkg/runtime/mem_linux.c File src/pkg/runtime/mem_linux.c (right): https://codereview.appspot.com/6997049/diff/2002/src/pkg/runtime/mem_linux.c#newcode68 src/pkg/runtime/mem_linux.c:68: runtime·printf("runtime: mmap: too much locked memory (check rlimits).\n"); check ...
9 years, 6 months ago (2012-12-23 13:35:22 UTC) #2
rsc
How can this happen?
9 years, 6 months ago (2012-12-23 19:22:02 UTC) #3
Sebastien Paolacci
On 2012/12/23 19:22:02, rsc wrote: > How can this happen? For exemple, by using `syscall.Mlockall(syscall.MCL_FUTURE)' ...
9 years, 6 months ago (2012-12-23 19:52:28 UTC) #4
Sebastien Paolacci
https://codereview.appspot.com/6997049/diff/2002/src/pkg/runtime/mem_linux.c File src/pkg/runtime/mem_linux.c (right): https://codereview.appspot.com/6997049/diff/2002/src/pkg/runtime/mem_linux.c#newcode68 src/pkg/runtime/mem_linux.c:68: runtime·printf("runtime: mmap: too much locked memory (check rlimits).\n"); On ...
9 years, 6 months ago (2012-12-23 19:56:08 UTC) #5
minux1
LGTM. Will wait for Russ's comment.
9 years, 6 months ago (2012-12-23 19:59:58 UTC) #6
rsc
LGTM
9 years, 6 months ago (2012-12-29 19:25:52 UTC) #7
rsc
Submitted but hg didn't manage to send mail about it. You may need to run ...
9 years, 6 months ago (2012-12-30 02:36:03 UTC) #8
gobot
Replacing golang-dev with golang-codereviews.
8 years, 6 months ago (2013-12-20 16:21:42 UTC) #9
dfc
8 years, 5 months ago (2014-01-31 00:42:56 UTC) #10
On 2013/12/20 16:21:42, gobot wrote:
> Replacing golang-dev with golang-codereviews.

R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b