Issue 6997048: code review 6997048: cmd/gc: do not generate code for var _ = ... unless nec...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6997048: code review 6997048: cmd/gc: do not generate code for var _ = ... unless nec... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

cmd/gc: do not generate code for var _ = ... unless necessary Fixes issue 2443.

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -6 lines)			Patch
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/init.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gc/sinit.c	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 2	2 chunks	+110 lines, -1 line	0 comments	Download
M	test/golden.out	View	1 2	1 chunk	+1 line, -5 lines	0 comments	Download
M	test/sinit.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2012-12-30 17:01:19 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=88ae367d61aa *** cmd/gc: do not generate code for var _ = ...

11 years, 3 months ago (2012-12-30 17:01:31 UTC) #2

Message was sent while issue was closed.

lgtm