Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(193)

Issue 69970044: code review 69970044: syscall: workaround Dragonfly BSD kernel exec bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by minux1
Modified:
11 years, 3 months ago
Reviewers:
gobot, iant
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

syscall: workaround Dragonfly BSD kernel exec bug See also CL 4259056 for FreeBSD. Test program: // exec.go package main import ( "log" "os" "os/exec" "runtime" ) func main() { path := runtime.GOROOT() + "/src/pkg/net/http/cgi/testdata" cmd := &exec.Cmd{ Path: "test.cgi", Args: []string{path + "/test.cgi"}, Dir: path Stdout: os.Stdout} if err := cmd.Start(); err != nil { log.Fatal(err) } if err := cmd.Wait(); err != nil { log.Fatal(err) } } $ go run exec.go 2014/03/01 15:52:41 fork/exec test.cgi: argument list too long

Patch Set 1 #

Patch Set 2 : diff -r 891e16653547 https://code.google.com/p/go #

Patch Set 3 : diff -r 891e16653547 https://code.google.com/p/go #

Patch Set 4 : diff -r d553518e7b1f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/syscall/exec_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
minux1
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2014-03-01 09:02:57 UTC) #1
iant
LGTM
11 years, 3 months ago (2014-03-01 23:00:00 UTC) #2
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=6f7f3ab0292a *** syscall: workaround Dragonfly BSD kernel exec bug See also CL ...
11 years, 3 months ago (2014-03-01 23:56:54 UTC) #3
gobot
This CL appears to have broken the linux-amd64-race builder.
11 years, 3 months ago (2014-03-02 00:26:46 UTC) #4
minux1
11 years, 3 months ago (2014-03-02 00:30:05 UTC) #5
On Sat, Mar 1, 2014 at 7:26 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-amd64-race builder.
>
Data race in net/http, unrelated.

>
> https://codereview.appspot.com/69970044/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b