Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(587)

Issue 6996044: code review 6996044: exp/cookiejar: dumbify the storage interface, add a bas... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
volker.dobler, bradfitz
CC:
golang-dev, rsc
Visibility:
Public.

Description

exp/cookiejar: dumbify the storage interface, add a basic Jar implementation. Update issue 1960.

Patch Set 1 #

Patch Set 2 : diff -r 5acb449b2a67 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5acb449b2a67 https://go.googlecode.com/hg/ #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -79 lines) Patch
M src/pkg/exp/cookiejar/jar.go View 1 2 chunks +198 lines, -18 lines 7 comments Download
A src/pkg/exp/cookiejar/jar_test.go View 1 1 chunk +336 lines, -0 lines 2 comments Download
M src/pkg/exp/cookiejar/storage.go View 1 2 chunks +106 lines, -61 lines 2 comments Download

Messages

Total messages: 4
nigeltao
Hello bradfitz@golang.org, dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2012-12-21 00:12:02 UTC) #1
bradfitz
I like dumbifying. https://codereview.appspot.com/6996044/diff/4001/src/pkg/exp/cookiejar/storage.go File src/pkg/exp/cookiejar/storage.go (right): https://codereview.appspot.com/6996044/diff/4001/src/pkg/exp/cookiejar/storage.go#newcode44 src/pkg/exp/cookiejar/storage.go:44: // TODO: should Keys instead be ...
11 years, 3 months ago (2012-12-21 21:22:43 UTC) #2
volker.dobler
I am very much in favor of this design. It will allow a clean and ...
11 years, 3 months ago (2012-12-22 00:27:10 UTC) #3
nigeltao
11 years, 1 month ago (2013-01-31 11:07:03 UTC) #4
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b