code review 6994047: exp/types: resolve composite literal keys

exp/types: resolve composite literal keys

The parser/resolver cannot accurately resolve
composite literal keys that are identifiers;
it needs type information.
Instead, try to resolve them but leave final
judgement to the type checker.

[gri, 2012-12-27 00:21:55]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[gri, 2012-12-27 00:51:24]

Hello adonovan@google.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adonovan, 2012-12-28 17:33:29]

LGTM

Thanks for the quick fix.

https://codereview.appspot.com/6994047/diff/1003/src/pkg/exp/types/expr.go
File src/pkg/exp/types/expr.go (right):

https://codereview.appspot.com/6994047/diff/1003/src/pkg/exp/types/expr.go#ne...
src/pkg/exp/types/expr.go:510: // compositeLitKey resolves unresolved composite
literal keys.
Might be good to add here:

  compositeLitKey resolves unresolved composite literal keys. 
  Such references are always to declarations in the file, package or universe
scope.
  For details...

[gri, 2012-12-28 18:40:19]

https://codereview.appspot.com/6994047/diff/1003/src/pkg/exp/types/expr.go
File src/pkg/exp/types/expr.go (right):

https://codereview.appspot.com/6994047/diff/1003/src/pkg/exp/types/expr.go#ne...
src/pkg/exp/types/expr.go:510: // compositeLitKey resolves unresolved composite
literal keys.
On 2012/12/28 17:33:29, adonovan wrote:
> Might be good to add here:
> 
>   compositeLitKey resolves unresolved composite literal keys. 
>   Such references are always to declarations in the file, package or universe
> scope.
>   For details...

Prefer to leave as is. There's a really long comment in the parser (as noted),
and the parser has really extensive comments about resolution.

[gri, 2012-12-28 18:40:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=d7f56af8557e ***

exp/types: resolve composite literal keys

The parser/resolver cannot accurately resolve
composite literal keys that are identifiers;
it needs type information.
Instead, try to resolve them but leave final
judgement to the type checker.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/6994047