Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 69890053: juju upgrade-juju - major version upgrades (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by wallyworld
Modified:
10 years, 1 month ago
Reviewers:
mp+209378, fwereade
Visibility:
Public.

Description

juju upgrade-juju - major version upgrades Previously, juju upgrade-juju rejected major version upgardes. They are now allowed, with some other changes. 1. No version specified If the CLI major version > agent major version, then the target version for upgrade is the CLI version. Where CLI major version = agent major version, then the minor version is bumped to the next stable release version as happens now. 2. Minor version downgrades not supported Tools matching has already been changed to match on major.minor, and the new upgrade infrastructure only supports upgrading, so we should disallow downgrades. https://code.launchpad.net/~wallyworld/juju-core/enable-major-upgrades/+merge/209378 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -22 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/upgradejuju.go View 4 chunks +27 lines, -17 lines 2 comments Download
M cmd/juju/upgradejuju_test.go View 4 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
10 years, 2 months ago (2014-03-05 07:03:01 UTC) #1
fwereade
LGTM https://codereview.appspot.com/69890053/diff/1/cmd/juju/upgradejuju.go File cmd/juju/upgradejuju.go (right): https://codereview.appspot.com/69890053/diff/1/cmd/juju/upgradejuju.go#newcode357 cmd/juju/upgradejuju.go:357: v.agent.Major, v.agent.Minor, v.chosen.Major, v.chosen.Minor) `%s to %s", v.agent, ...
10 years, 2 months ago (2014-03-06 15:06:43 UTC) #2
wallyworld
10 years, 2 months ago (2014-03-06 21:48:10 UTC) #3
https://codereview.appspot.com/69890053/diff/1/cmd/juju/upgradejuju.go
File cmd/juju/upgradejuju.go (right):

https://codereview.appspot.com/69890053/diff/1/cmd/juju/upgradejuju.go#newcod...
cmd/juju/upgradejuju.go:357: v.agent.Major, v.agent.Minor, v.chosen.Major,
v.chosen.Minor)
On 2014/03/06 15:06:43, fwereade wrote:
> `%s to %s", v.agent, v.chosen`?

I was wanting to only include major.minor in the error message because that's
what the decision was based on. But perhaps we should just print the full
version. I've changed it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b