Issue 69890043: upgrades: change syslog-port on upgrade

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69890043: upgrades: change syslog-port on upgrade

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by axw

Modified:
10 years, 2 months ago

Reviewers:
mp+208724, wallyworld

Visibility:
Public.

Description

upgrades: change syslog-port on upgrade We upgrade syslog-port to 6514, to work around a problem with older versions of rsyslog to do with privileged ports. There are some incidental changes here: - fixed AllMachines handling in upgrades - provide *state.State to state server upgrade context https://code.launchpad.net/~axwalk/juju-core/upgrade-syslog-port/+merge/208724 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : upgrades: change syslog-port on upgrade #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -10 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1	6 chunks	+19 lines, -3 lines	0 comments	Download
M	cmd/jujud/upgrade_test.go	View	1	3 chunks	+32 lines, -0 lines	0 comments	Download
M	testing/testbase/cmd.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	upgrades/export_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	upgrades/rsyslogport.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
A	upgrades/rsyslogport_test.go	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
M	upgrades/steps118.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	upgrades/steps118_test.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	upgrades/upgrade.go	View		5 chunks	+17 lines, -4 lines	0 comments	Download
M	upgrades/upgrade_test.go	View		4 chunks	+25 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wallyworld

Looks great but there are missing tests for the rsyslogport upgrade function as well as ...

10 years, 2 months ago (2014-02-28 04:43:51 UTC) #2

axw

Please take a look. https://codereview.appspot.com/69890043/diff/1/upgrades/rsyslogport.go File upgrades/rsyslogport.go (right): https://codereview.appspot.com/69890043/diff/1/upgrades/rsyslogport.go#newcode18 upgrades/rsyslogport.go:18: }) On 2014/02/28 04:43:51, wallyworld ...

10 years, 2 months ago (2014-02-28 05:58:19 UTC) #3

LGTM

Expand All Messages | Collapse All Messages