Issue 69870055: code review 69870055: runtime: fix runaway memory usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69870055: code review 69870055: runtime: fix runaway memory usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dvyukov

Modified:
11 years ago

Reviewers:
gobot, khr

CC:
golang-codereviews, khr, rsc

Visibility:
Public.

Description

runtime: fix runaway memory usage It was caused by mstats.heap_alloc skew. Fixes issue 7430.

Patch Set 1 #

Patch Set 2 : diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 7a45730704af https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
M	src/pkg/runtime/malloc.goc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/mcache.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years ago (2014-03-06 11:52:49 UTC) #1

khr

On 2014/03/06 11:52:49, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org, mailto:rsc@golang.org), > > I'd like ...

11 years ago (2014-03-06 17:24:31 UTC) #2

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=6e03d65b755b *** runtime: fix runaway memory usage It was caused by mstats.heap_alloc ...

11 years ago (2014-03-06 17:33:06 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-race builder.

Expand All Messages | Collapse All Messages