Issue 69860055: code review 69860055: cmd/dist: respect system CFLAGS/LDFLAGS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69860055: code review 69860055: cmd/dist: respect system CFLAGS/LDFLAGS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by atom

Modified:
11 years ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

cmd/dist: respect system CFLAGS/LDFLAGS Update issue 6882.

Patch Set 1 #

Patch Set 2 : diff -r 4cd83f2e218e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4cd83f2e218e https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	src/cmd/dist/build.c	View	1	7 chunks	+27 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

atom

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years ago (2014-03-05 11:41:19 UTC) #1

rsc

11 years ago (2014-03-05 19:10:28 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7e40ed7e3c80 ***

cmd/dist: respect system CFLAGS/LDFLAGS

Update issue 6882.

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/69860055

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages