Issue 69860044: code review 69860044: INSTALL: fix architecture detection on Solaris.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69860044: code review 69860044: INSTALL: fix architecture detection on Solaris. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by minux1

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
rsc

Visibility:
Public.

Description

INSTALL: fix architecture detection on Solaris. And uses gcc for i386 and x86_64.

Patch Set 1 #

Patch Set 2 : diff -r 18c38bf29b0b https://code.google.com/p/plan9port #

Patch Set 3 : diff -r 18c38bf29b0b https://code.google.com/p/plan9port #

Patch Set 4 : diff -r 18c38bf29b0b https://code.google.com/p/plan9port #

Patch Set 5 : diff -r 0c036a6d4d22 https://code.google.com/p/plan9port #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	INSTALL	View	1 2 3	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org, I'd like you to review this change to https://code.google.com/p/plan9port

10 years, 10 months ago (2014-03-01 09:03:35 UTC) #1

minux1

10 years, 10 months ago (2014-03-05 21:43:24 UTC) #3

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=89f7e02f1256 ***

INSTALL: fix architecture detection on Solaris.
And uses gcc for i386 and x86_64.

LGTM=rsc
R=rsc
https://codereview.appspot.com/69860044

Expand All Messages | Collapse All Messages