Issue 69850043: Identify the arm64 architecture.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69850043: Identify the arm64 architecture.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by thumper

Modified:
10 years, 2 months ago

Reviewers:
dave, mp+208721

Visibility:
Public.

Description

Identify the arm64 architecture. Created from patches on lp bug 1276909. https://code.launchpad.net/~thumper/juju-core/arm64-identification/+merge/208721 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	constraints/constraints.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/imagemetadata/simplestreams.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/manual/init.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/tools/tools.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	instance/instance.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	provider/ec2/ec2.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	provider/openstack/provider.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/release-public-tools/release-public-tools.sh	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 2 months ago (2014-02-28 03:34:55 UTC) #2

On 2014/02/28 03:24:15, thumper wrote:
> Please take a look.

LGTM. Does it give you hives that those constants are repeated over and over
again ?

Expand All Messages | Collapse All Messages