Issue 69830043: code review 69830043: image/jpeg: return a FormatError when hitting an unexpe...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 69830043: code review 69830043: image/jpeg: return a FormatError when hitting an unexpe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by nigeltao

Modified:
11 years, 3 months ago

Reviewers:
r, gobot

CC:
r, golang-codereviews

Visibility:
Public.

Description

image/jpeg: return a FormatError when hitting an unexpected io.EOF inside Huffman-encoded data. Fixes issue 6450.

Patch Set 1 #

Patch Set 2 : diff -r 7648764d8f9b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7648764d8f9b https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6065b50b2768 https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/pkg/image/jpeg/huffman.go	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-02-28 02:13:05 UTC) #1

nigeltao

*** Submitted as https://code.google.com/p/go/source/detail?r=f62cd90ce0d8 *** image/jpeg: return a FormatError when hitting an unexpected io.EOF inside ...

11 years, 3 months ago (2014-02-28 04:20:44 UTC) #3

gobot

11 years, 3 months ago (2014-02-28 04:25:58 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-race builder.

Expand All Messages | Collapse All Messages