Issue 6976049: code review 6976049: godoc: really restore toy selection to playground widget

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6976049: code review 6976049: godoc: really restore toy selection to playground widget

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by amir

Modified:
10 years, 10 months ago

Reviewers:
minux1, adg, khr, golang-dev

Visibility:
Public.

Description

godoc: really restore toy selection to playground widget playground.js include is removed in revision 1676e21191aa which fixes issue 4225, rendering toy selection nonfunctional.

Patch Set 1 #

Patch Set 2 : diff -r 1fd839e10187 https://code.google.com/p/go #

Patch Set 3 : diff -r 1fd839e10187 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	doc/root.html	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

amir

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-12-22 13:16:34 UTC) #1

minux1

LGTM. Tested in Firefox. +adg. I wonder why CL 6640054 remove the inclusion of playground.js? ...

11 years, 4 months ago (2012-12-22 14:17:07 UTC) #2

adg

NOT LGTM This is intended behavior. The playground.js file is now included by lib/godoc/godoc.html, but ...

11 years, 3 months ago (2013-01-02 03:28:44 UTC) #3

R=close

Expand All Messages | Collapse All Messages