Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3171)

Issue 6976046: Allow using an own SSL cert and private key.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by frankban
Modified:
11 years, 4 months ago
Reviewers:
mp+141105
Visibility:
Public.

Description

Allow using an own SSL cert and private key. Added two new config options, one for the certificate, one for the private key. If they are both provided, they are used by nginx, otherwise, a new certificate is automatically generated. Fixed a pre-existent bug: even if you can specify the directory where to store the certificates, this path was not used by nginx, because an hardcoded one was present in the configuration file. Improved how ssl options are handled in config-changes. If the SSL path is changed using 'juju set', now that change is reflected in the nginx config file, and the service correctly restarted. Added tests for the process of saving or generating SSL certificates. Some code clean up. Please note that all the SSL stuff is still disabled/commented. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1092515-certificates/+merge/141105 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Allow using an own SSL cert and private key. #

Patch Set 3 : Allow using an own SSL cert and private key. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -24 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 chunk +12 lines, -0 lines 0 comments Download
M config/nginx.conf.template View 1 chunk +2 lines, -2 lines 0 comments Download
M hooks/config-changed View 3 chunks +13 lines, -4 lines 0 comments Download
M hooks/install View 2 chunks +5 lines, -1 line 0 comments Download
M hooks/start View 1 chunk +3 lines, -1 line 0 comments Download
M hooks/utils.py View 6 chunks +30 lines, -14 lines 0 comments Download
M tests/test_utils.py View 3 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
11 years, 4 months ago (2012-12-21 17:47:13 UTC) #1
frankban
Please take a look.
11 years, 4 months ago (2012-12-21 17:53:32 UTC) #2
teknico
Land as is. Great job.
11 years, 4 months ago (2012-12-21 18:22:43 UTC) #3
matthew.scott
Looks good to me, land as is. Thanks for the changes.
11 years, 4 months ago (2012-12-21 20:01:57 UTC) #4
gary.poster
I'm distracted that I can't run the tests successfully--part of the problem was that a ...
11 years, 4 months ago (2012-12-21 22:49:06 UTC) #5
frankban
11 years, 4 months ago (2012-12-22 10:51:52 UTC) #6
*** Submitted:

Allow using an own SSL cert and private key.

Added two new config options, one for the certificate, one
for the private key. If they are both provided, they are used
by nginx, otherwise, a new certificate is automatically 
generated.

Fixed a pre-existent bug: even if you can specify the 
directory where to store the certificates, this path 
was not used by nginx, because an hardcoded one was
present in the configuration file.

Improved how ssl options are handled in config-changes.
If the SSL path is changed using 'juju set', now that
change is reflected in the nginx config file, and the
service correctly restarted.

Added tests for the process of saving or generating SSL
certificates.

Some code clean up.

Please note that all the SSL stuff is still 
disabled/commented.

R=teknico, matthew.scott, gary.poster
CC=
https://codereview.appspot.com/6976046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b