Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 6970051: code review 6970051: cmd/godoc: ignore misnamed examples and print a warning

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by kisielk
Modified:
9 years, 6 months ago
Reviewers:
adg
CC:
golang-dev, adg
Visibility:
Public.

Description

cmd/godoc: ignore misnamed examples and print a warning Fixes issue 4211.

Patch Set 1 #

Patch Set 2 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Patch Set 3 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Total comments: 3

Patch Set 4 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Total comments: 5

Patch Set 5 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Total comments: 2

Patch Set 6 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Total comments: 8

Patch Set 7 : diff -r 5acb449b2a67 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -24 lines) Patch
M src/cmd/godoc/godoc.go View 1 2 3 4 5 6 3 chunks +91 lines, -24 lines 0 comments Download

Messages

Total messages: 12
kisielk
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-12-20 04:27:35 UTC) #1
adg
https://codereview.appspot.com/6970051/diff/3001/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/6970051/diff/3001/src/cmd/godoc/godoc.go#newcode895 src/cmd/godoc/godoc.go:895: func declInPackages(p map[string]*ast.Package, name string) bool { split this ...
9 years, 6 months ago (2012-12-20 04:59:22 UTC) #2
kisielk
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-20 05:43:04 UTC) #3
adg
https://codereview.appspot.com/6970051/diff/6003/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/6970051/diff/6003/src/cmd/godoc/godoc.go#newcode894 src/cmd/godoc/godoc.go:894: // with a matching name period. https://codereview.appspot.com/6970051/diff/6003/src/cmd/godoc/godoc.go#newcode908 src/cmd/godoc/godoc.go:908: // ...
9 years, 6 months ago (2012-12-20 05:49:33 UTC) #4
kisielk
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-20 06:03:58 UTC) #5
adg
https://codereview.appspot.com/6970051/diff/2002/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/6970051/diff/2002/src/cmd/godoc/godoc.go#newcode951 src/cmd/godoc/godoc.go:951: if name == "" || hasGlobalName(pkgs, name) { I ...
9 years, 6 months ago (2012-12-20 06:14:03 UTC) #6
kisielk
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-20 07:35:41 UTC) #7
kisielk
https://codereview.appspot.com/6970051/diff/2002/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/6970051/diff/2002/src/cmd/godoc/godoc.go#newcode951 src/cmd/godoc/godoc.go:951: if name == "" || hasGlobalName(pkgs, name) { On ...
9 years, 6 months ago (2012-12-20 07:38:19 UTC) #8
adg
Way better! https://codereview.appspot.com/6970051/diff/7002/src/cmd/godoc/godoc.go File src/cmd/godoc/godoc.go (right): https://codereview.appspot.com/6970051/diff/7002/src/cmd/godoc/godoc.go#newcode895 src/cmd/godoc/godoc.go:895: func declName(decl ast.Decl) []string { func declNames(decl ...
9 years, 6 months ago (2012-12-20 20:21:48 UTC) #9
kisielk
Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-21 06:08:24 UTC) #10
adg
LGTM
9 years, 6 months ago (2013-01-02 04:11:53 UTC) #11
adg
9 years, 6 months ago (2013-01-02 05:00:58 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=0dfd8fcdbca5 ***

cmd/godoc: ignore misnamed examples and print a warning

Fixes issue 4211.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6970051

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b