Issue 6968051: Improved documentation and comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6968051: Improved documentation and comments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dimitern

Modified:
11 years, 4 months ago

Reviewers:
mp+140893

Visibility:
Public.

Description

Improved documentation and comments. I took an old branch of mine with some more comments merged them into the current state of trunk. Old branch is at: https://code.launchpad.net/~dimitern/goose/client-refactoring/+merge/134873 (but I'll remove it, once this lands). https://code.launchpad.net/~dimitern/goose/client-comments/+merge/140893 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improved documentation and comments. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -23 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/client.go	View	1	7 chunks	+25 lines, -4 lines	0 comments	Download
M	glance/glance.go	View		5 chunks	+8 lines, -1 line	0 comments	Download
M	identity/identity.go	View		5 chunks	+18 lines, -4 lines	0 comments	Download
M	nova/nova.go	View		12 chunks	+23 lines, -13 lines	0 comments	Download
M	swift/swift.go	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM https://codereview.appspot.com/6968051/diff/1/client/client.go File client/client.go (right): https://codereview.appspot.com/6968051/diff/1/client/client.go#newcode13 client/client.go:13: In other projects I've worked on, we omit ...

11 years, 4 months ago (2012-12-20 13:03:31 UTC) #2

dimitern

11 years, 4 months ago (2012-12-20 15:00:54 UTC) #3

*** Submitted:

Improved documentation and comments.

I took an old branch of mine with some more comments merged them into the
current state of trunk.

Old branch is at:
https://code.launchpad.net/~dimitern/goose/client-refactoring/+merge/134873
(but I'll remove it, once this lands).

R=jameinel
CC=
https://codereview.appspot.com/6968051

https://codereview.appspot.com/6968051/diff/1/client/client.go
File client/client.go (right):

https://codereview.appspot.com/6968051/diff/1/client/client.go#newcode13
client/client.go:13: 
On 2012/12/20 13:03:31, jameinel wrote:
> In other projects I've worked on, we omit the Written by stuff, and just have
it
> tracked in the source control tool. Otherwise it generally just ends up wrong.
> I'm open to discussion, but eventually you end up with everyone on the
extended
> team. I think an "AUTHORS" file might be better?

Ok, I'll remove that.

https://codereview.appspot.com/6968051/diff/1/client/client.go#newcode101
client/client.go:101: // IsAuthenticated returns true, if there is an establised
session.
On 2012/12/20 13:03:31, jameinel wrote:
> I think the ',' is wrong here.

Done.

Expand All Messages | Collapse All Messages