Issue 6966047: Openstack security group api compat with hpcloud

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6966047: Openstack security group api compat with hpcloud

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by hazmat

Modified:
11 years, 3 months ago

Reviewers:
mp+140815

Visibility:
Public.

Description

Openstack security group api compat with hpcloud It looks like the issue is the server security group details don't have rule information in the diablo/hpcloud api fallback which caused problems for juju when trying to determine what ports where open in the group (couldn't close ports, and attempted to open ports multiple times). The simple workaround is a specific path for hpcloud that fetches the group detail info separately if server group details don't have rule info. Verified against folsom/canonistack and hpcloud/diablo. https://bugs.launchpad.net/juju/+bug/1092343 https://code.launchpad.net/~hazmat/juju/ostack-diablo-hp-compat/+merge/140815 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -19 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/openstack/client.py	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download
M	juju/providers/openstack/ports.py	View	1 2	5 chunks	+27 lines, -10 lines	0 comments	Download
M	juju/providers/openstack/tests/test_ports.py	View	1	2 chunks	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

11 years, 3 months ago (2013-01-14 10:52:37 UTC) #3

*** Submitted:

Openstack security group api compat with hpcloud

It looks like the issue is the server security group details don't have rule 
information in the diablo/hpcloud api fallback which caused problems for juju 
when trying to determine what ports where open in the group (couldn't close 
ports, and attempted to open ports multiple times). The simple workaround is a 
specific path for hpcloud that fetches the group detail info separately if 
server group details don't have rule info. 

Verified against folsom/canonistack and hpcloud/diablo.

https://bugs.launchpad.net/juju/+bug/1092343

R=
CC=
https://codereview.appspot.com/6966047

Expand All Messages | Collapse All Messages