environs/cloudinit: refactor tests

environs/cloudinit: refactor tests

In an upcoming CL, I was starting to add ever more
logic to the script tests, and a different approach seemed
like a better way.

By specifying the entire script in the tests, we
get a much better idea of what the cloudinit
scripts will look like as a whole, making it
easier to diagnose problems earlier.

The down side is we'll need to change the tests
more often, but they're easier to change, and
it seems like less smoke and mirrors.

https://code.launchpad.net/~rogpeppe/juju-core/182-cloudinit-refactor-tests/+merge/140909

(do not edit description out of merge proposal)

[rog, 2012-12-20 14:28:31]

Please take a look.

[fwereade, 2012-12-20 17:09:03]

LGTM

https://codereview.appspot.com/6963050/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/6963050/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:112: cat >>
/etc/init/jujud-machine-99\.conf <<
'EOF'\\n.*/var/lib/juju/tools/machine-99/jujud machine --state-servers
'state-addr\.example\.com' --ca-cert '/var/lib/juju/ca-cert\.pem' --log-file
/var/log/juju/machine-99\.log --data-dir '/var/lib/juju' --initial-password
'arble' --machine-id 99  --debug >> /var/log/juju/machine-99\.log.*
Man, this is an ugly line. But I think the cause is good.

[TheMue, 2013-01-11 16:47:03]

LGTM

https://codereview.appspot.com/6963050/diff/1/environs/cloudinit/cloudinit_te...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/6963050/diff/1/environs/cloudinit/cloudinit_te...
environs/cloudinit/cloudinit_test.go:112: cat >>
/etc/init/jujud-machine-99\.conf <<
'EOF'\\n.*/var/lib/juju/tools/machine-99/jujud machine --state-servers
'state-addr\.example\.com' --ca-cert '/var/lib/juju/ca-cert\.pem' --log-file
/var/log/juju/machine-99\.log --data-dir '/var/lib/juju' --initial-password
'arble' --machine-id 99  --debug >> /var/log/juju/machine-99\.log.*
On 2012/12/20 17:09:03, fwereade wrote:
> Man, this is an ugly line. But I think the cause is good.

Yep, like above. But here the script only may use earlier set variables. For a
manual maintained script maybe ok, for a generated one like this here in
production IMHO not needed.

[rog, 2013-01-11 16:52:25]

*** Submitted:

environs/cloudinit: refactor tests

In an upcoming CL, I was starting to add ever more
logic to the script tests, and a different approach seemed
like a better way.

By specifying the entire script in the tests, we
get a much better idea of what the cloudinit
scripts will look like as a whole, making it
easier to diagnose problems earlier.

The down side is we'll need to change the tests
more often, but they're easier to change, and
it seems like less smoke and mirrors.

R=fwereade, TheMue
CC=
https://codereview.appspot.com/6963050