Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1737)

Issue 6962044: Fix broken symbolic links in release tarballs.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by frankban
Modified:
11 years, 5 months ago
Reviewers:
mp+140662
Visibility:
Public.

Description

Fix broken symbolic links in release tarballs. Now, when the release is created (make distfile) the symbolic links are followed. Another solution could be to create relative links in "make build*". However, I preferred to dereference the links for two reasons: - it is simple; - it allows uncompresing our release also in filesystems not supporting symlinks. https://code.launchpad.net/~frankban/juju-gui/distfile-fixes/+merge/140662 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix broken symbolic links in release tarballs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Makefile View 1 chunk +3 lines, -2 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
11 years, 5 months ago (2012-12-19 13:09:21 UTC) #1
benji
Looks good.
11 years, 5 months ago (2012-12-19 13:19:23 UTC) #2
gary.poster
Land as is. Very nice. Didn't know about that option. Thank you. Gary
11 years, 5 months ago (2012-12-19 13:28:11 UTC) #3
frankban
Benji, Gary, thanks for the reviews.
11 years, 5 months ago (2012-12-19 13:29:18 UTC) #4
frankban
11 years, 5 months ago (2012-12-19 13:32:15 UTC) #5
*** Submitted:

Fix broken symbolic links in release tarballs.

Now, when the release is created (make distfile) the symbolic links
are followed.

Another solution could be to create relative links in "make build*".
However, I preferred to dereference the links for two reasons:
- it is simple;
- it allows uncompresing our release also in filesystems not supporting
  symlinks.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6962044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b