Issue 6954043: Fix intermittent d3.v2.min.js Makefile error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6954043: Fix intermittent d3.v2.min.js Makefile error

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by gary.poster

Modified:
11 years, 5 months ago

Reviewers:
mp+140560

Visibility:
Public.

Description

Fix intermittent d3.v2.min.js Makefile error This file failed intermittently because the symlink was wrong. The symlink was wrong because our use of PWD was fragile. This is a simple fix. https://code.launchpad.net/~gary/juju-gui/pwd/+merge/140560 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix intermittent d3.v2.min.js Makefile error #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	Makefile	View		1 chunk	+7 lines, -6 lines	0 comments	Download
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

11 years, 5 months ago (2012-12-18 22:23:24 UTC) #3

*** Submitted:

Fix intermittent d3.v2.min.js Makefile error

This file failed intermittently because the symlink was wrong.  The symlink was
wrong because our use of PWD was fragile.  This is a simple fix.

R=
CC=
https://codereview.appspot.com/6954043

Expand All Messages | Collapse All Messages