code review 69530044: syscall: add some paranoia in Linux's Accept4

syscall: add some paranoia in Linux's Accept4

Fixes Issue 7428

[bradfitz, 2014-02-27 21:55:05]

Hello r@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-02-27 21:55:35]

If you want it.



On Thu, Feb 27, 2014 at 1:55 PM, <bradfitz@golang.org> wrote:

> Reviewers: r,
>
> Message:
> Hello r@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: add some paranoia in Linux's Accept4
>
> Please review this at https://codereview.appspot.com/69530044/
>
> Affected files (+3, -0 lines):
>   M src/pkg/syscall/syscall_linux.go
>
>
> Index: src/pkg/syscall/syscall_linux.go
> ===================================================================
> --- a/src/pkg/syscall/syscall_linux.go
> +++ b/src/pkg/syscall/syscall_linux.go
> @@ -420,6 +420,9 @@
>         if err != nil {
>                 return
>         }
> +       if len > SizeofSockaddrAny {
> +               panic("RawSockaddrAny too small")
> +       }
>         sa, err = anyToSockaddr(&rsa)
>         if err != nil {
>                 Close(nfd)
>
>
>

[r, 2014-02-27 22:12:15]

LGTM

[bradfitz, 2014-02-27 22:16:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=f59cadfcb3f7 ***

syscall: add some paranoia in Linux's Accept4

Fixes Issue 7428

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/69530044