Issue 6949073: code review 6949073: cmd/gc: Reject parenthesised .(type) expressions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6949073: code review 6949073: cmd/gc: Reject parenthesised .(type) expressions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by DMorsing

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: Reject parenthesised .(type) expressions. Fixes issue 4470.

Patch Set 1 #

Patch Set 2 : diff -r c082c3be7168 https://code.google.com/p/go/ #

Patch Set 3 : diff -r c082c3be7168 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 948c7bbdd29d https://code.google.com/p/go/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -165 lines)			Patch
M	src/cmd/gc/go.y	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/y.tab.c	View	1	146 chunks	+166 lines, -165 lines	0 comments	Download
A	test/fixedbugs/issue4470.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 6 months ago (2012-12-18 20:10:27 UTC) #1

DMorsing

12 years, 6 months ago (2012-12-22 16:36:35 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a244dfa507e0 ***

cmd/gc: Reject parenthesised .(type) expressions.

Fixes issue 4470.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6949073

Expand All Messages | Collapse All Messages