Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(430)

Issue 6949058: code review 6949058: time: fix panic with time.Parse(time.StampNano, ... ) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by dfc
Modified:
8 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

time: fix panic with time.Parse(time.StampNano, ... ) Fixes issue 4502.

Patch Set 1 #

Patch Set 2 : diff -r ee5afd4b14b7 https://code.google.com/p/go #

Patch Set 3 : diff -r ee5afd4b14b7 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 9e8d16052155 https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 111aa291b561 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/pkg/time/format.go View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
M src/pkg/time/time_test.go View 1 2 3 4 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 5
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 1 month ago (2012-12-15 03:09:26 UTC) #1
rsc
https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go File src/pkg/time/time_test.go (right): https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go#newcode637 src/pkg/time/time_test.go:637: {StampNano, "Dec 7 11:22:01.000000", "extra text: .000000"}, This is ...
8 years, 1 month ago (2012-12-17 00:43:40 UTC) #2
dfc
Thank you for your feedback, please take another look. https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go File src/pkg/time/time_test.go (right): https://codereview.appspot.com/6949058/diff/6001/src/pkg/time/time_test.go#newcode637 src/pkg/time/time_test.go:637: ...
8 years, 1 month ago (2012-12-17 03:51:31 UTC) #3
rsc
LGTM https://codereview.appspot.com/6949058/diff/1003/src/pkg/time/time_test.go File src/pkg/time/time_test.go (right): https://codereview.appspot.com/6949058/diff/1003/src/pkg/time/time_test.go#newcode520 src/pkg/time/time_test.go:520: {"", "Jan _2 15:04:05.999", "Feb 4 21:00:57.012300000", false, ...
8 years, 1 month ago (2012-12-17 16:09:36 UTC) #4
dfc
8 years, 1 month ago (2012-12-17 20:54:12 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=9a0e4777ea8b ***

time: fix panic with time.Parse(time.StampNano, ... )

Fixes issue 4502.

R=rsc
CC=golang-dev
https://codereview.appspot.com/6949058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b