Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(716)

Issue 6948071: code review 6948071: exp/types: configurable types.Check API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by gri
Modified:
11 years, 3 months ago
Reviewers:
CC:
adonovan, rsc, golang-dev
Visibility:
Public.

Description

exp/types: configurable types.Check API - added Context type for configuration of type checker - type check all function and method bodies - (partial) fixes to shift hinting (still not complete) - revamped test harness - does not rely on specific position representation anymore, just a standard (compiler) error message - lots of bug fixes

Patch Set 1 #

Patch Set 2 : diff -r e29b9036a11a https://code.google.com/p/go #

Patch Set 3 : diff -r e29b9036a11a https://code.google.com/p/go #

Patch Set 4 : diff -r e7cd0a82d669 https://code.google.com/p/go #

Patch Set 5 : diff -r 0c135754c93a https://code.google.com/p/go #

Total comments: 8

Patch Set 6 : diff -r 0c135754c93a https://code.google.com/p/go #

Patch Set 7 : diff -r 5acb449b2a67 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 220ddfb20066 https://code.google.com/p/go #

Patch Set 9 : diff -r 220ddfb20066 https://code.google.com/p/go #

Total comments: 11

Patch Set 10 : diff -r 220ddfb20066 https://code.google.com/p/go #

Patch Set 11 : diff -r 220ddfb20066 https://code.google.com/p/go #

Patch Set 12 : diff -r 220ddfb20066 https://code.google.com/p/go #

Patch Set 13 : diff -r b9bee6184b4e https://code.google.com/p/go #

Patch Set 14 : diff -r b9bee6184b4e https://code.google.com/p/go #

Patch Set 15 : diff -r b9bee6184b4e https://code.google.com/p/go #

Patch Set 16 : diff -r 24d25f5ef821 https://code.google.com/p/go #

Patch Set 17 : diff -r 6fdc1974457c https://code.google.com/p/go #

Patch Set 18 : diff -r 6fdc1974457c https://code.google.com/p/go #

Patch Set 19 : diff -r 87f67aadaed6 https://code.google.com/p/go/ #

Patch Set 20 : diff -r 87f67aadaed6 https://code.google.com/p/go/ #

Patch Set 21 : diff -r 87f67aadaed6 https://code.google.com/p/go/ #

Patch Set 22 : diff -r aa5d9f234a8e https://code.google.com/p/go #

Total comments: 8

Patch Set 23 : diff -r 2c8a88c1efce https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -299 lines) Patch
M src/pkg/exp/gotype/gotype.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -6 lines 0 comments Download
M src/pkg/exp/gotype/gotype_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 8 chunks +20 lines, -17 lines 0 comments Download
A src/pkg/exp/types/api.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +65 lines, -0 lines 0 comments Download
M src/pkg/exp/types/builtins.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 6 chunks +59 lines, -12 lines 0 comments Download
M src/pkg/exp/types/check.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 9 chunks +121 lines, -68 lines 0 comments Download
M src/pkg/exp/types/check_test.go View 1 2 3 4 5 6 7 8 9 10 5 chunks +65 lines, -68 lines 0 comments Download
M src/pkg/exp/types/const.go View 1 2 3 20 chunks +39 lines, -39 lines 0 comments Download
M src/pkg/exp/types/errors.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +12 lines, -8 lines 0 comments Download
M src/pkg/exp/types/expr.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 9 chunks +66 lines, -42 lines 0 comments Download
M src/pkg/exp/types/operand.go View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -1 line 0 comments Download
M src/pkg/exp/types/stmt.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 7 chunks +22 lines, -5 lines 0 comments Download
M src/pkg/exp/types/testdata/builtins.src View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +16 lines, -0 lines 0 comments Download
M src/pkg/exp/types/testdata/decls1.src View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/exp/types/testdata/decls2a.src View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/exp/types/testdata/expr0.src View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +16 lines, -0 lines 0 comments Download
M src/pkg/exp/types/testdata/stmt0.src View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/exp/types/types.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +1 line, -21 lines 0 comments Download
M src/pkg/exp/types/types_test.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 8
adonovan
Looks good. https://codereview.appspot.com/6948071/diff/8001/src/pkg/exp/types/api.go File src/pkg/exp/types/api.go (right): https://codereview.appspot.com/6948071/diff/8001/src/pkg/exp/types/api.go#newcode32 src/pkg/exp/types/api.go:32: // The first token.Pos or token.Position value ...
11 years, 3 months ago (2012-12-19 23:17:02 UTC) #1
gri
FYI https://codereview.appspot.com/6948071/diff/8001/src/pkg/exp/types/api.go File src/pkg/exp/types/api.go (right): https://codereview.appspot.com/6948071/diff/8001/src/pkg/exp/types/api.go#newcode32 src/pkg/exp/types/api.go:32: // The first token.Pos or token.Position value in ...
11 years, 3 months ago (2012-12-20 00:47:47 UTC) #2
rsc
Until Go 1.1 happens we can always tweak this, so I don't think we need ...
11 years, 3 months ago (2012-12-20 20:38:17 UTC) #3
gri
Done. I had added the Config type after the handlers (because I still needed a ...
11 years, 3 months ago (2012-12-21 01:14:19 UTC) #4
gri
Hello adonovan@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2012-12-21 02:01:11 UTC) #5
adonovan
LGTM Thanks for exposing Complex and NilType and fixing the gaps in copy() and method ...
11 years, 3 months ago (2012-12-26 20:37:33 UTC) #6
gri
Thanks. https://codereview.appspot.com/6948071/diff/41001/src/pkg/exp/gotype/gotype_test.go File src/pkg/exp/gotype/gotype_test.go (right): https://codereview.appspot.com/6948071/diff/41001/src/pkg/exp/gotype/gotype_test.go#newcode55 src/pkg/exp/gotype/gotype_test.go:55: // Unless there is comment next to the ...
11 years, 3 months ago (2012-12-26 20:42:09 UTC) #7
gri
11 years, 3 months ago (2012-12-26 20:48:33 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=2e40253cdd9b ***

exp/types: configurable types.Check API

- added Context type for configuration of type checker
- type check all function and method bodies
- (partial) fixes to shift hinting (still not complete)
- revamped test harness - does not rely on specific position
  representation anymore, just a standard (compiler) error
  message
- lots of bug fixes

R=adonovan, rsc
CC=golang-dev
https://codereview.appspot.com/6948071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b