Doc: NR Moved Appendix C to CG

Doc: NR Moved Appendix C to CG

Issue 3015

[Trevor Daniels, 2012-12-17 23:43:58]

Hi James

Thanks for tackling this - it would be hard for
me to do as compiling the full docs takes ages
on my laptop.  That means I haven't actually
tested the suggestions I've made.  Hope they
work!

Trevor

https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi
File Documentation/contributor.texi (right):

https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi#...
Documentation/contributor.texi:74: @verbatiminclude ly-grammar.txt
The text needs to go just before the
@include fdl.itexi
near the end of this file.
Just the * LilyPond grammar:: line should
appear in the menu block.
You'll also need to prefix the text with
@node LilyPond grammar
@appendix LilyPond grammar

https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation...
File Documentation/notation/notation-appendices.itely (left):

https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation...
Documentation/notation/notation-appendices.itely:1545: (BNF) in @ref{LilyPond
grammar}.  This file is used to build the
How about leaving this paragraph in, simply
changing the @ref{} to @rcontrib{}?  It is in a
Technical glossary, so I don't mind the technicalities
being mentioned here.  What do you think?

[pkx166h, 2012-12-25 06:45:56]

https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi
File Documentation/contributor.texi (right):

https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi#...
Documentation/contributor.texi:74: @verbatiminclude ly-grammar.txt
On 2012/12/17 23:43:58, Trevor Daniels wrote:
> The text needs to go just before the
> @include fdl.itexi
> near the end of this file.
> Just the * LilyPond grammar:: line should
> appear in the menu block.
> You'll also need to prefix the text with
> @node LilyPond grammar
> @appendix LilyPond grammar

Done.

https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation...
File Documentation/notation/notation-appendices.itely (left):

https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation...
Documentation/notation/notation-appendices.itely:1545: (BNF) in @ref{LilyPond
grammar}.  This file is used to build the
On 2012/12/17 23:43:58, Trevor Daniels wrote:
> How about leaving this paragraph in, simply
> changing the @ref{} to @rcontrib{}?  It is in a
> Technical glossary, so I don't mind the technicalities
> being mentioned here.  What do you think?

Done.

[Trevor Daniels, 2012-12-25 08:05:45]

Once the docs build this will be ready
to go.

https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi
File Documentation/contributor.texi (right):

https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.te...
Documentation/contributor.texi:70: 
Drop the blank line

https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely
File Documentation/notation.tely (left):

https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely#...
Documentation/notation.tely:88: @node LilyPond grammar
You'll need to find and drop the menu item
corresponding to this node, else the docs
won't build.

[pkx166h, 2012-12-26 08:14:24]

https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi
File Documentation/contributor.texi (right):

https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.te...
Documentation/contributor.texi:70: 
On 2012/12/25 08:05:45, Trevor Daniels wrote:
> Drop the blank line

Done.

https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely
File Documentation/notation.tely (left):

https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely#...
Documentation/notation.tely:88: @node LilyPond grammar
On 2012/12/25 08:05:45, Trevor Daniels wrote:
> You'll need to find and drop the menu item
> corresponding to this node, else the docs
> won't build.

Done.

[Trevor Daniels, 2012-12-26 10:09:45]

LGTM, apart from a couple of nitpicks which
I missed earlier.  No need to post a new
patch-set.

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
File Documentation/notation/notation-appendices.itely (left):

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1545: (BNF) in @ref{LilyPond
grammar}.  This file is used to build the
Our standard is two spaces after full stops in
mono-spaced text.

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1534: @cindex grammar, for
LilyPond
I think the comma is wrong here.  "grammar for Lilypond"
is perfectly sensible.

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1547: parser during the program
build by the parser generator, Bison. It is
Same here.

[pkx166h, 2012-12-26 13:09:52]

Minor Nit picks

[pkx166h, 2012-12-26 13:11:37]

Minor Nit picks

[pkx166h, 2012-12-26 13:14:06]

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
File Documentation/notation/notation-appendices.itely (left):

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1545: (BNF) in @ref{LilyPond
grammar}.  This file is used to build the
On 2012/12/26 10:09:45, Trevor Daniels wrote:
> Our standard is two spaces after full stops in
> mono-spaced text.

Done.

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
File Documentation/notation/notation-appendices.itely (right):

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1534: @cindex grammar, for
LilyPond
On 2012/12/26 10:09:45, Trevor Daniels wrote:
> I think the comma is wrong here.  "grammar for Lilypond"
> is perfectly sensible.

Done.

https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notat...
Documentation/notation/notation-appendices.itely:1547: parser during the program
build by the parser generator, Bison. It is
On 2012/12/26 10:09:45, Trevor Daniels wrote:
> Same here.

Done.

[Graham Percival, 2012-12-29 02:03:51]

LGTM

[pkx166h, 2012-12-31 11:01:45]

author	James Lowe <pkx166h@gmail.com>	
Mon, 17 Dec 2012 21:52:03 +0000 (21:52 +0000)
committer	James Lowe <pkx166h@gmail.com>	
Mon, 31 Dec 2012 10:58:11 +0000 (10:58 +0000)
commit	00cd4ff0b8dc4978344ba966bec06ddbc445f7e9