code review 6948066: exp/gotype: more tests and fix for Windows build (hopefully)

exp/gotype: disable failing tests and add a few more

[gri, 2012-12-17 21:06:35]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2012-12-17 22:05:58]

Still broken:

C:\go\root\src\pkg\exp\gotype>go test
c:\go\root\src\pkg\net\interface_windows.go:54:13: invalid operation: division
by zero
c:\go\root\src\pkg\syscall\syscall_windows.go:35:16: cannot convert EINVAL
(constant 536870951) to error
--- FAIL: Test (2.27 seconds)
gotype_test.go:45:      processing net failed: exitCode = 2
gotype_test.go:45:      processing syscall failed: exitCode = 2
FAIL
exit status 1
FAIL    exp/gotype      2.484s

[gri, 2012-12-17 22:11:27]

PTAL. Could you please try one more time? I don't have a Windows build
ready at the moment. Thanks.
- gri

On Mon, Dec 17, 2012 at 2:05 PM,  <alex.brainman@gmail.com> wrote:
> Still broken:
>
> C:\go\root\src\pkg\exp\gotype>go test
> c:\go\root\src\pkg\net\interface_windows.go:54:13: invalid operation:
> division by zero
> c:\go\root\src\pkg\syscall\syscall_windows.go:35:16: cannot convert
> EINVAL (constant 536870951) to error
> --- FAIL: Test (2.27 seconds)
> gotype_test.go:45:      processing net failed: exitCode = 2
> gotype_test.go:45:      processing syscall failed: exitCode = 2
> FAIL
> exit status 1
> FAIL    exp/gotype      2.484s
>
>
> https://codereview.appspot.com/6948066/

[brainman, 2012-12-17 22:15:54]

On 2012/12/17 22:11:27, gri wrote:
> PTAL. ...

Works now. Cannot say much about your change - I do not know enough.

Alex

[gri, 2012-12-17 22:19:17]

Thanks. I simply disabled the tests that don't work yet (due to bugs
in my code).
- gri

On Mon, Dec 17, 2012 at 2:15 PM,  <alex.brainman@gmail.com> wrote:
> On 2012/12/17 22:11:27, gri wrote:
>>
>> PTAL. ...
>
>
> Works now. Cannot say much about your change - I do not know enough.
>
> Alex
>
> https://codereview.appspot.com/6948066/

[brainman, 2012-12-17 22:20:54]

On 2012/12/17 22:19:17, gri wrote:
> ... I simply disabled the tests that don't work yet (due to bugs
> in my code)....

Sure thing. LGTM.

Alex

[gri, 2012-12-17 22:32:53]

*** Submitted as https://code.google.com/p/go/source/detail?r=e29b9036a11a ***

exp/gotype: disable failing tests and add a few more

R=rsc, alex.brainman
CC=golang-dev
https://codereview.appspot.com/6948066